This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] tst-tlsopt-powerpc as a shared lib
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>, Alan Modra <amodra at gmail dot com>, Adam Conrad <adconrad at 0c3 dot net>
- Cc: Tulio Magno Quites Machado Filho <tuliom at linux dot vnet dot ibm dot com>, Josh Stone <jistone at redhat dot com>, libc-alpha at sourceware dot org, binutils at sourceware dot org, Matthias Klose <doko at ubuntu dot com>, Steven Munroe <sjmunroe at us dot ibm dot com>
- Date: Tue, 5 Sep 2017 07:36:20 -0500
- Subject: Re: [PATCH] tst-tlsopt-powerpc as a shared lib
- Authentication-results: sourceware.org; auth=none
- References: <00ac3cbe-47f4-ccf0-3017-c1f2ab43db20@redhat.com> <30946d0a-a095-f5cb-bf0b-d3897712cdab@redhat.com> <ef3da09f-5e98-223c-8e77-68c724c12df7@redhat.com> <be439468-44fe-6cf1-0519-d03e50dd8432@redhat.com> <20170727040411.GX14520@bubble.grove.modra.org> <d61a7515-31b7-5799-948c-25aa77fa2d76@redhat.com> <20170727234529.GZ14520@bubble.grove.modra.org> <20170728090246.GA1956@bubble.grove.modra.org> <20170728130744.GU21230@0c3.net> <20170730000430.GF1956@bubble.grove.modra.org> <6cfed5f0-f559-de75-c9f3-4caff4101273@redhat.com>
On 09/04/2017 04:39 PM, Florian Weimer wrote:
> On 07/30/2017 02:04 AM, Alan Modra wrote:
>> * sysdeps/powerpc/mod-tlsopt-powerpc.c: Extract from
>> tst-tlsopt-powerpc.c with function name change and no test harness.
>> * sysdeps/powerpc/tst-tlsopt-powerpc.c: Remove body of test.
>> Call tls_get_addr_opt_test.
>> * sysdeps/powerpc/Makefile (LDFLAGS-tst-tlsopt-powerpc): Don't define.
>> (modules-names): Add mod-tlsopt-powerpc.
>> (mod-tlsopt-powerpc.so-no-z-defs): Define.
>> (tst-tlsopt-powerpc): Depend on .so.
>> * sysdeps/powerpc/powerpc64/tls-macros.h (__TLS_GET_ADDR): Don't
>> define. Expand use in TLS_GD and TLS_LD.
>
> Should we backport this to the active release branches?
Yes. Test fixes that make the active branches easier to maintain for the
distributions are always a good idea.
--
Cheers,
Carlos.