This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gold: PR gold/21857: Add clear_ch_reserved to 64-bit Chdr_write

On Fri, Jul 28, 2017 at 1:29 PM, Cary Coutant <ccoutant@gmail.com> wrote:
>> The 64-bit ELF compression header has a reserved field.  It should be
>> cleared to avoid random bits in it.
>>
>> elfcpp/
>>
>>       PR gold/21857
>>       * elfcpp.h (Chdr_write): Add put_ch_reserved.
>>       (Chdr_write<64, true>::put_ch_reserved): New.
>>       (Chdr_write<64, false>::put_ch_reserved): Likewise.
>>
>> gold/
>>
>>       PR gold/21857
>>       * compressed_output.cc (Output_compressed_section::set_final_data_size):
>>       Call put_ch_reserved to clear the reserved field for 64-bit ELF..
>
> This is OK (but delete that second period in the ChangeLog entry). Thanks!
>
> -cary

Done and checked it into master, 2.28 and 2.29 branches.

Thanks.


-- 
H.J.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]