This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: BFD internal errors in *_finish_dynamic_symbol
- From: jose dot marchesi at oracle dot com (Jose E. Marchesi)
- To: Egeyar Bagcioglu <egeyar dot bagcioglu at oracle dot com>
- Cc: Jiong Wang <jiong dot wang at foss dot arm dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>, Joseph Myers <joseph at codesourcery dot com>, binutils at sourceware dot org
- Date: Mon, 03 Jul 2017 20:09:55 +0200
- Subject: Re: BFD internal errors in *_finish_dynamic_symbol
- Authentication-results: sourceware.org; auth=none
- References: <alpine.DEB.2.20.1706292120510.22519@digraph.polyomino.org.uk> <091dd7a5-b986-74d7-1a16-fb8e1a392785@foss.arm.com> <67b72a5a-2637-5910-19b2-c9d7348bc209@foss.arm.com> <61d89fbe-d20e-71ff-afec-e77474c2944a@oracle.com> <a484f966-3c46-9f08-b312-dd2499488099@oracle.com>
Hi Egeyar.
bfd/ChangeLog:
2017-07-03 Egeyar Bagcioglu <egeyar.bagcioglu@oracle.com>
* elfxx-sparc.c (_bfd_sparc_elf_finish_dynamic_symbol): Remove the
abort statement that was put for symbols that are not dynamic.
---
bfd/elfxx-sparc.c | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/bfd/elfxx-sparc.c b/bfd/elfxx-sparc.c
index 1fd2141..b50d34b 100644
--- a/bfd/elfxx-sparc.c
+++ b/bfd/elfxx-sparc.c
@@ -4502,13 +4502,6 @@ _bfd_sparc_elf_finish_dynamic_symbol (bfd *output_bfd,
eh = (struct _bfd_sparc_elf_link_hash_entry *) h;
- /* Abort if the symbol is not dynamic in PIC */
- if (h->dynindx == -1
- && !h->forced_local
- && h->root.type != bfd_link_hash_undefweak
- && bfd_link_pic (info))
- abort();
-
/* We keep PLT/GOT entries without dynamic PLT/GOT relocations for
resolved undefined weak symbols in executable so that their
references have value 0 at run-time. */
I just applied this in master.