This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[committed 2/2] MIPS/opcodes: Correctly combine ASE flags for ASE_MIPS16E2_MT calculation
- From: "Maciej W. Rozycki" <macro at imgtec dot com>
- To: <binutils at sourceware dot org>
- Date: Fri, 30 Jun 2017 00:59:25 +0100
- Subject: [committed 2/2] MIPS/opcodes: Correctly combine ASE flags for ASE_MIPS16E2_MT calculation
- Authentication-results: sourceware.org; auth=none
- References: <alpine.DEB.2.00.1706292343221.31404@tp.orcam.me.uk>
Correct a commit 25499ac7ee92 ("MIPS16e2: Add MIPS16e2 ASE support")
disassembler bug with the handling of the ASE_MIPS16E2_MT combination
ASE flag, where the calculation uses MIPS ABI Flags directly rather than
calculated internal ASE flags. Consequently code does not correctly set
the ASE_MIPS16E2_MT flag when the MIPS16e2 ASE flag and the MT ASE flag
come from different sources, i.e. one from the BFD chosen and the other
one from MIPS ABI Flags.
Fix this by using internal ASE_MT and ASE_MIPS16E2 flags in a separate
subsequent step, factored out to a dedicated function for use with
future combination ASE flags. Adjust the `mips16e2@mips16e2-mt-sub.d'
test case accordingly, where the MT flag comes from the BFD selected for
the disassembler and the MIPS16e2 flag comes from the ELF binary itself.
opcodes/
* mips-dis.c (mips_calculate_combination_ases): New function.
(mips_convert_abiflags_ases): Factor out ASE_MIPS16E2_MT
calculation to the new function.
(set_default_mips_dis_options): Call the new function.
gas/
* testsuite/gas/mips/mips16e2@mips16e2-mt-sub.d: Adjust for the
ASE_MIPS16E2_MT flag disassembler fix.
* testsuite/gas/mips/mips16e2-interaptiv-mr2@mips16e2-mt-sub.d:
Likewise.
---
binutils-mips16e2-opcodes-combination-ases-fix.diff
Index: binutils/gas/testsuite/gas/mips/mips16e2-interaptiv-mr2@mips16e2-mt-sub.d
===================================================================
--- binutils.orig/gas/testsuite/gas/mips/mips16e2-interaptiv-mr2@mips16e2-mt-sub.d 2017-06-29 02:39:05.262451226 +0100
+++ binutils/gas/testsuite/gas/mips/mips16e2-interaptiv-mr2@mips16e2-mt-sub.d 2017-06-29 02:39:21.015438710 +0100
@@ -2,21 +2,4 @@
#name: MIPS16e2 MT ASE subset disassembly
#as: -32 -I$srcdir/$subdir
#source: mips16e2-mt-sub.s
-
-.*: +file format .*mips.*
-
-Disassembly of section \.text:
-[0-9a-f]+ <[^>]*> f0c0 3010 ehb
-[0-9a-f]+ <[^>]*> f026 6701 dmt
-[0-9a-f]+ <[^>]*> f026 6701 dmt
-[0-9a-f]+ <[^>]*> f022 6741 dmt v0
-[0-9a-f]+ <[^>]*> f027 6701 emt
-[0-9a-f]+ <[^>]*> f027 6701 emt
-[0-9a-f]+ <[^>]*> f023 6741 emt v0
-[0-9a-f]+ <[^>]*> f026 6700 dvpe
-[0-9a-f]+ <[^>]*> f026 6700 dvpe
-[0-9a-f]+ <[^>]*> f022 6740 dvpe v0
-[0-9a-f]+ <[^>]*> f027 6700 evpe
-[0-9a-f]+ <[^>]*> f027 6700 evpe
-[0-9a-f]+ <[^>]*> f023 6740 evpe v0
- \.\.\.
+#dump: mips16e2@mips16e2-mt-sub.d
Index: binutils/gas/testsuite/gas/mips/mips16e2@mips16e2-mt-sub.d
===================================================================
--- binutils.orig/gas/testsuite/gas/mips/mips16e2@mips16e2-mt-sub.d 2017-06-29 02:39:05.280643216 +0100
+++ binutils/gas/testsuite/gas/mips/mips16e2@mips16e2-mt-sub.d 2017-06-29 02:39:21.028599154 +0100
@@ -7,28 +7,16 @@
Disassembly of section \.text:
[0-9a-f]+ <[^>]*> f0c0 3010 ehb
-[0-9a-f]+ <[^>]*> f026 extend 0x26
-[0-9a-f]+ <[^>]*> 6701 move s0,at
-[0-9a-f]+ <[^>]*> f026 extend 0x26
-[0-9a-f]+ <[^>]*> 6701 move s0,at
-[0-9a-f]+ <[^>]*> f022 extend 0x22
-[0-9a-f]+ <[^>]*> 6741 move v0,at
-[0-9a-f]+ <[^>]*> f027 extend 0x27
-[0-9a-f]+ <[^>]*> 6701 move s0,at
-[0-9a-f]+ <[^>]*> f027 extend 0x27
-[0-9a-f]+ <[^>]*> 6701 move s0,at
-[0-9a-f]+ <[^>]*> f023 extend 0x23
-[0-9a-f]+ <[^>]*> 6741 move v0,at
-[0-9a-f]+ <[^>]*> f026 extend 0x26
-[0-9a-f]+ <[^>]*> 6700 move s0,zero
-[0-9a-f]+ <[^>]*> f026 extend 0x26
-[0-9a-f]+ <[^>]*> 6700 move s0,zero
-[0-9a-f]+ <[^>]*> f022 extend 0x22
-[0-9a-f]+ <[^>]*> 6740 move v0,zero
-[0-9a-f]+ <[^>]*> f027 extend 0x27
-[0-9a-f]+ <[^>]*> 6700 move s0,zero
-[0-9a-f]+ <[^>]*> f027 extend 0x27
-[0-9a-f]+ <[^>]*> 6700 move s0,zero
-[0-9a-f]+ <[^>]*> f023 extend 0x23
-[0-9a-f]+ <[^>]*> 6740 move v0,zero
+[0-9a-f]+ <[^>]*> f026 6701 dmt
+[0-9a-f]+ <[^>]*> f026 6701 dmt
+[0-9a-f]+ <[^>]*> f022 6741 dmt v0
+[0-9a-f]+ <[^>]*> f027 6701 emt
+[0-9a-f]+ <[^>]*> f027 6701 emt
+[0-9a-f]+ <[^>]*> f023 6741 emt v0
+[0-9a-f]+ <[^>]*> f026 6700 dvpe
+[0-9a-f]+ <[^>]*> f026 6700 dvpe
+[0-9a-f]+ <[^>]*> f022 6740 dvpe v0
+[0-9a-f]+ <[^>]*> f027 6700 evpe
+[0-9a-f]+ <[^>]*> f027 6700 evpe
+[0-9a-f]+ <[^>]*> f023 6740 evpe v0
\.\.\.
Index: binutils/opcodes/mips-dis.c
===================================================================
--- binutils.orig/opcodes/mips-dis.c 2017-06-29 01:50:04.420433102 +0100
+++ binutils/opcodes/mips-dis.c 2017-06-29 23:32:51.670207156 +0100
@@ -805,12 +805,21 @@ mips_convert_abiflags_ases (unsigned lon
opcode_ases |= ASE_DSPR3;
if (afl_ases & AFL_ASE_MIPS16E2)
opcode_ases |= ASE_MIPS16E2;
- if ((afl_ases & (AFL_ASE_MIPS16E2 | AFL_ASE_MT))
- == (AFL_ASE_MIPS16E2 | AFL_ASE_MT))
- opcode_ases |= ASE_MIPS16E2_MT;
return opcode_ases;
}
+/* Calculate combination ASE flags from regular ASE flags. */
+
+static unsigned long
+mips_calculate_combination_ases (unsigned long opcode_ases)
+{
+ unsigned long combination_ases = 0;
+
+ if ((opcode_ases & (ASE_MIPS16E2 | ASE_MT)) == (ASE_MIPS16E2 | ASE_MT))
+ combination_ases |= ASE_MIPS16E2_MT;
+ return combination_ases;
+}
+
static void
set_default_mips_dis_options (struct disassemble_info *info)
{
@@ -880,6 +889,7 @@ set_default_mips_dis_options (struct dis
mips_ase |= ASE_MDMX;
}
#endif
+ mips_ase |= mips_calculate_combination_ases (mips_ase);
}
static void