Re: [PATCH 10/10 GAS/ARM] Add support for ARM Cortex-R52 processor

[Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>]

I've changed the patch to add an entry to the binutils 2.29 section rather than 
2.28. I've also fixed a typo in the entry (Cortex-R52 instead of Cortex-r52) 
Patch committed in attachment.

Best regards,

Thomas

On 21/06/17 15:58, Richard Earnshaw (lists) wrote:
> On 21/06/17 11:16, Thomas Preudhomme wrote:
> > Hi,
> >
> > === Context ===
> >
> > This patch is part of a patch series to add support for ARMv8-R
> > architecture. Its purpose is to add support for ARM Cortex-R52
> > processor.
> >
> > === Patch description ===
> >
> > This patch adds support for Cortex-R52 as an ARMv8-R processor with CRC
> > extensions.
> >
> > ChangeLog entry is as follows:
> >
> > *** gas/ChangeLog ***
> >
> > 2017-01-31  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> >
> >      * NEWS: Mention support of ARM Cortex-R52 processor.
> >      * config/tc-arm.c (arm_cpus): Add entry for ARM Cortex-R52 processor.
> >      * doc/c-arm.texi: Mention support for -mcpu=cortex-r52.
> >
> > === Testing ===
> >
> > Testsuite shows no regression when run for arm-none-eabi targets.
> >
> > Is this ok for master branch?
> >
> > Best regards,
> >
> > Thomas
> >
> > 10_add_cortex-r52_support.patch
> >
> >
> > diff --git a/gas/NEWS b/gas/NEWS
> > index 1897502078d387db0eb5a28c45a945c6a89b42be..cca9c3ac24b7edbcd438620e49a5e7c96a2fa1be 100644
> > --- a/gas/NEWS
> > +++ b/gas/NEWS
> > @@ -10,7 +10,7 @@ Changes in 2.28:
> >   
> >   * Add support for the RISC-V architecture.
> >   
> > -* Add support for the ARM Cortex-M23 and Cortex-M33 processors.
> > +* Add support for the ARM Cortex-M23, Cortex-M33 and Cortex-r52 processors.
> >   
> >   * Support for the ARMv8-R architecture has been added to the ARM port.
> >   
> > diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c
> > index 8f6ea96f56f974ea6252892ff0d7399e5fb47537..737cd66896930999999c5f97ee1e490ec77ae0e9 100644
> > --- a/gas/config/tc-arm.c
> > +++ b/gas/config/tc-arm.c
> > @@ -25742,6 +25742,9 @@ static const struct arm_cpu_option_table arm_cpus[] =
> >     ARM_CPU_OPT ("cortex-r8",	  "Cortex-R8",	       ARM_ARCH_V7R,
> >   	       ARM_FEATURE_CORE_LOW (ARM_EXT_ADIV),
> >   	       FPU_ARCH_VFP_V3D16),
> > +  ARM_CPU_OPT ("cortex-r52",	  "Cortex-R52",	       ARM_ARCH_V8R,
> > +	      ARM_FEATURE_COPROC (CRC_EXT_ARMV8),
> > +	      FPU_ARCH_NEON_VFP_ARMV8),
> >     ARM_CPU_OPT ("cortex-m33",	  "Cortex-M33",	       ARM_ARCH_V8M_MAIN,
> >   	       ARM_FEATURE_CORE_LOW (ARM_EXT_V5ExP | ARM_EXT_V6_DSP),
> >   	       FPU_NONE),
> > diff --git a/gas/doc/c-arm.texi b/gas/doc/c-arm.texi
> > index 596c8af90ca15f85a63f177151e3463b4f635315..455223cbeeece01dacb01f9c33a20d833d940d1d 100644
> > --- a/gas/doc/c-arm.texi
> > +++ b/gas/doc/c-arm.texi
> > @@ -131,6 +131,7 @@ recognized:
> >   @code{cortex-r5},
> >   @code{cortex-r7},
> >   @code{cortex-r8},
> > +@code{cortex-52},
>
> cortex-r52
>
> >   @code{cortex-m33},
> >   @code{cortex-m23},
> >   @code{cortex-m7},
>
> OK with that change.
>
> R.
diff --git a/gas/NEWS b/gas/NEWS
index 18de4d009f15f4a3686f577ef3c7ef07a934177e..b4ee6b625c46ab83a9b0609a84083c0c8d5200ad 100644
--- a/gas/NEWS
+++ b/gas/NEWS
@@ -10,7 +10,8 @@
 
 * Add support for the Texas Instruments PRU processor.
 
-* Support for the ARMv8-R architecture has been added to the ARM port.
+* Support for the ARMv8-R architecture and Cortex-R52 processor has been
+  added to the ARM port.
 
 Changes in 2.28:
 
diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c
index b0f2832a27be9871a6b70e381eca56b28d4bc47b..3c37b4f1a265f3562134b05bbb22d7fd7d10cc8a 100644
--- a/gas/config/tc-arm.c
+++ b/gas/config/tc-arm.c
@@ -25780,6 +25780,9 @@ static const struct arm_cpu_option_table arm_cpus[] =
   ARM_CPU_OPT ("cortex-r8",	  "Cortex-R8",	       ARM_ARCH_V7R,
 	       ARM_FEATURE_CORE_LOW (ARM_EXT_ADIV),
 	       FPU_ARCH_VFP_V3D16),
+  ARM_CPU_OPT ("cortex-r52",	  "Cortex-R52",	       ARM_ARCH_V8R,
+	      ARM_FEATURE_COPROC (CRC_EXT_ARMV8),
+	      FPU_ARCH_NEON_VFP_ARMV8),
   ARM_CPU_OPT ("cortex-m33",	  "Cortex-M33",	       ARM_ARCH_V8M_MAIN,
 	       ARM_FEATURE_CORE_LOW (ARM_EXT_V5ExP | ARM_EXT_V6_DSP),
 	       FPU_NONE),
diff --git a/gas/doc/c-arm.texi b/gas/doc/c-arm.texi
index 379c011fc98cda5e8507d562e8b9520e7a6c197e..31a012ea1b754b1a1c4f7ac8c2a2ee129abfe208 100644
--- a/gas/doc/c-arm.texi
+++ b/gas/doc/c-arm.texi
@@ -131,6 +131,7 @@ recognized:
 @code{cortex-r5},
 @code{cortex-r7},
 @code{cortex-r8},
+@code{cortex-r52},
 @code{cortex-m33},
 @code{cortex-m23},
 @code{cortex-m7},