This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] [ARC] Update conditions for illegal placed instructions.
- From: Nick Clifton <nickc at redhat dot com>
- To: Claudiu Zissulescu <Claudiu dot Zissulescu at synopsys dot com>, binutils at sourceware dot org
- Cc: Francois dot Bedard at synopsys dot com
- Date: Wed, 21 Jun 2017 09:03:17 +0100
- Subject: Re: [PATCH] [ARC] Update conditions for illegal placed instructions.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=nickc at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 563C08E37A
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 563C08E37A
- References: <1496844087-11896-1-git-send-email-claziss@synopsys.com>
Hi Claudiu,
> gas/
> 2017-06-07 Claudiu Zissulescu <claziss@synopsys.com>
>
> * /config/tc-arc.c (is_br_jmp_insn_p): Update macro with known
> instructions to be accounted as jumps.
> (assemble_insn): Check for limms into the delay slots. Emit an
> error if so.
> * testsuite/gas/arc/asm-errors-3.d: New file.
> * testsuite/gas/arc/asm-errors-3.err: Likewise.
> * testsuite/gas/arc/asm-errors-3.s: Likewise.
Approved - please apply.
Cheers
Nick
PS. Sorry for the delay.
PPS: Looking to the future, if you add more classes of ARC instructions
then the is_br_jmp_insn macro might need updating. I was wondering if it
would be better if the type of instruction were encoded into the opcode
structure directly, so that you do not need to test for a whole range of
classes...