This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][gold, aarch64] Skip ERRATUM 843419 fix if the sequences have been relaxed by TLS optimization

From: Cary Coutant <ccoutant at gmail dot com>
To: Han Shen <shenhan at google dot com>
Cc: Jiong Wang <jiong dot wang at foss dot arm dot com>, Andrew Pinski <pinskia at gmail dot com>, binutils <binutils at sourceware dot org>, Luis Lozano <llozano at google dot com>
Date: Wed, 14 Jun 2017 17:07:18 -0700
Subject: Re: [PATCH][gold, aarch64] Skip ERRATUM 843419 fix if the sequences have been relaxed by TLS optimization
Authentication-results: sourceware.org; auth=none
References: <CACkGtriWCQ=g-0WGY0wuLUp6PZ+sgpFcJz2cEbtSE5RCkdXTmA@mail.gmail.com> <CA+=Sn1kwk5CXGSmMNYkKcaxxJq2g4OCfB7agDYerq00nsaSnkA@mail.gmail.com> <CACkGtri0jy=YocqcpTgT7ceE+Ogd9ZsbThvh8eTtE8VYpq_sTw@mail.gmail.com> <6284fdb4-6075-ab71-ab01-22657e505425@foss.arm.com> <2eae4d05-737a-5e7a-186a-bd6b29b74b55@foss.arm.com> <CACkGtrhUskeWQZtq70O4Ai+pkLQdocyAWLzcUfBVbjeks3whng@mail.gmail.com> <5bd1d77c-0c03-9bd1-73d7-c16c8756a7bc@foss.arm.com> <CACkGtrgsBduuEtyxPA7biFrWJNHTTnyYsZw_Xr_doEni3iGYJA@mail.gmail.com>

> Yup, let's change "return  false;" -> "return true;" (and add proper comments).
> Also, I assume this relaxation-changing-instructions behavior should
> not break erratum 835769? Erratum 843419 must have adrp as its first
> insn, whereas 835769 begins with LD/ST.
>
> Otherwise, LGTM

This is OK with me (with Han's suggested changes). It doesn't look
like this is related to any outstanding PR, but if it is, please add
the PR number to the ChangeLog.

-cary

Follow-Ups:
- [COMMITTED][gold, aarch64] Skip ERRATUM 843419 fix if the sequences have been relaxed by TLS optimization
  - From: Jiong Wang

References:
- Re: [gold][aarch64]: Erratum 843419 optimized fix
  - From: Jiong Wang
- [PATCH][gold, aarch64] Skip ERRATUM 843419 fix if the sequences have been relaxed by TLS optimization
  - From: Jiong Wang
- Re: [PATCH][gold, aarch64] Skip ERRATUM 843419 fix if the sequences have been relaxed by TLS optimization
  - From: Han Shen via binutils
- Re: [PATCH][gold, aarch64] Skip ERRATUM 843419 fix if the sequences have been relaxed by TLS optimization
  - From: Jiong Wang
- Re: [PATCH][gold, aarch64] Skip ERRATUM 843419 fix if the sequences have been relaxed by TLS optimization
  - From: Han Shen via binutils

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]