This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] bfd: Check ELF_COMMON_DEF_P on aarch64 for common symbols
- From: Nick Clifton <nickc at redhat dot com>
- To: James Clarke <jrtc27 at jrtc27 dot com>
- Cc: Binutils <binutils at sourceware dot org>, "H.J. Lu" <hjl dot tools at gmail dot com>, Renlin Li <renlin dot li at arm dot com>
- Date: Tue, 13 Jun 2017 16:00:10 +0100
- Subject: Re: [PATCH] bfd: Check ELF_COMMON_DEF_P on aarch64 for common symbols
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=nickc at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0E054C00AFC3
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0E054C00AFC3
- References: <20170525184504.12219-1-jrtc27@jrtc27.com> <620448a2-0821-d9d9-0dcd-e490d763f92d@redhat.com> <F40D72EF-F43E-4C66-9F79-921CFBFDA22D@jrtc27.com>
Hi James,
>>> PR ld/19579
>>> * elfnn-aarch64.c (elfNN_aarch64_finish_dynamic_symbol): Check
>>> ELF_COMMON_DEF_P for common symbols. Aarch64 was missed in
>>> 8170f7693bc0a9442c0aa280197925db92d48ca6.
>>
>> Approved and applied. Thanks very much for spotting this.
>
> Thanks; could you please backport to the 2.28 branch too?
Done.
Cheers
Nick