This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] X86: Disassemble primary opcode map's group 2 ModRM.reg == 6 aliases correctly

>>> On 28.05.17 at 22:32, <bp@suse.de> wrote:
> --- a/opcodes/i386-dis.c
> +++ b/opcodes/i386-dis.c
> @@ -3438,7 +3438,7 @@ static const struct dis386 reg_table[][8] = {
>      { "rcrA",	{ Eb, Ib }, 0 },
>      { "shlA",	{ Eb, Ib }, 0 },
>      { "shrA",	{ Eb, Ib }, 0 },
> -    { Bad_Opcode },
> +    { "shlA",	{ Eb, Ib }, 0 },
>      { "sarA",	{ Eb, Ib }, 0 },

I think it would be slightly better to name all these opcodes SAL.
That way the output would immediately make clear that it's the
alias which is in use, and it would be in line with its neighbor
being SAR.

Jan
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]