This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFC 2/5] xtensa: make configuration dynamic
- From: "augustine dot sterling at gmail dot com" <augustine dot sterling at gmail dot com>
- To: Max Filippov <jcmvbkbc at gmail dot com>
- Cc: binutils at sourceware dot org, gdb-patches at sourceware dot org, David Weatherford <weath at cadence dot com>, Maxim Grigoriev <maxim2405 at gmail dot com>, Woody LaRue <larue at cadence dot com>
- Date: Fri, 26 May 2017 11:10:12 -0700
- Subject: Re: [RFC 2/5] xtensa: make configuration dynamic
- Authentication-results: sourceware.org; auth=none
- References: <1495487553-19078-1-git-send-email-jcmvbkbc@gmail.com> <1495487553-19078-3-git-send-email-jcmvbkbc@gmail.com>
On Mon, May 22, 2017 at 2:12 PM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> Now that XCHAL_* macros don't have to be preprocessor constants add
> include/xtensa-dynconfig.h that defines them as fields of a structure
> returned from the xtensa_get_config function.
> Define that structure and fill it with default parameter values
> specified in the include/xtensa-config.h.
> Define reusable function xtensa_load_config that tries to load
> configuration and return an address of an exported object from it.
> Define the function xtensa_get_config that uses xtensa_load_config to
> get structure xtensa_config, either dynamically configured or the
> default.
>
> 2017-05-22 Max Filippov <jcmvbkbc@gmail.com>
> bfd/
> * Makefile.am (BFD32_BACKENDS, BFD32_BACKENDS_CFILES): Append
> xtensa-config.c.
> * Makefile.in: Regenerate.
> * configure: Regenerate.
> * configure.ac (xtensa_elf32_be_vec, xtensa_elf32_le_vec): Add
> xtensa-config.lo to the tb.
> * elf32-xtensa.c (xtensa-config.h): Replace #include with
> xtensa-dynconfig.h.
> * xtensa-config.c: New file.
>
> gas/
> * config/tc-xtensa.c (xtensa-config.h): Replace #include with
> xtensa-dynconfig.h.
> * config/tc-xtensa.h: Likewise.
> * config/xtensa-relax.c: Likewise.
>
> include/
> * xtensa-dynconfig.h: New file.
>
> ld/
> * Makefile.am (eelf32xtensa.c): Add $(INCDIR)/xtensa-dynconfig.h
> to the list of dependencies.
> * Makefile.in: Regenerate.
> * emultempl/xtensaelf.em (xtensa-config.h): Replace #include
> with xtensa-dynconfig.h.
This is ok.