This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH] bfd: Check ELF_COMMON_DEF_P on aarch64 for common symbols
- From: James Clarke <jrtc27 at jrtc27 dot com>
- To: binutils at sourceware dot org
- Cc: James Clarke <jrtc27 at jrtc27 dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>
- Date: Thu, 25 May 2017 19:45:04 +0100
- Subject: [PATCH] bfd: Check ELF_COMMON_DEF_P on aarch64 for common symbols
- Authentication-results: sourceware.org; auth=none
bfd/
PR ld/19579
* elfnn-aarch64.c (elfNN_aarch64_finish_dynamic_symbol): Check
ELF_COMMON_DEF_P for common symbols. Aarch64 was missed in
8170f7693bc0a9442c0aa280197925db92d48ca6.
---
bfd/elfnn-aarch64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c
index 2ff2120ffb..1edf2a0bde 100644
--- a/bfd/elfnn-aarch64.c
+++ b/bfd/elfnn-aarch64.c
@@ -8949,7 +8949,7 @@ elfNN_aarch64_finish_dynamic_symbol (bfd *output_bfd,
}
else if (bfd_link_pic (info) && SYMBOL_REFERENCES_LOCAL (info, h))
{
- if (!h->def_regular)
+ if (!(h->def_regular || ELF_COMMON_DEF_P (h)))
return FALSE;
BFD_ASSERT ((h->got.offset & 1) != 0);
--
2.13.0