This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: recent x86 testsuite failures
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Alan Modra <amodra at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Wed, 10 May 2017 10:56:02 -0700
- Subject: Re: recent x86 testsuite failures
- Authentication-results: sourceware.org; auth=none
- References: <20170510025514.GC30859@bubble.grove.modra.org>
On Tue, May 9, 2017 at 7:55 PM, Alan Modra <amodra@gmail.com> wrote:
> The first one is due to _bfd_elf_make_dynamic_reloc_section being
> called with a NULL dynobj, resulting in a segfault.
>
> i386-lynxos +FAIL: ld-misc/defsym1
> i386-lynxos +FAIL: ld-scripts/empty-address-1
>
This is what I checked in.
Thanks.
--
H.J.
---
commit 5d69120bfff3e532242083acd636dc68f23ea831
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Wed May 10 10:51:35 2017 -0700
i386: Set CHECK_RELOCS_AFTER_OPEN_INPUT to yes
All linker targets based on elf32-i386 should check relocations after
opening all inputs since this is how elf32-i386 works.
* emulparams/i386lynx.sh (CHECK_RELOCS_AFTER_OPEN_INPUT): Set
to yes.
* emulparams/i386moss.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
Likewise.
* emulparams/i386nw.sh (CHECK_RELOCS_AFTER_OPEN_INPUT): Likewise.
diff --git a/ld/ChangeLog b/ld/ChangeLog
index 2dfb06e..eb1fa7d 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,5 +1,13 @@
2017-05-10 H.J. Lu <hongjiu.lu@intel.com>
+ * emulparams/i386lynx.sh (CHECK_RELOCS_AFTER_OPEN_INPUT): Set
+ to yes.
+ * emulparams/i386moss.sh (CHECK_RELOCS_AFTER_OPEN_INPUT):
+ Likewise.
+ * emulparams/i386nw.sh (CHECK_RELOCS_AFTER_OPEN_INPUT): Likewise.
+
+2017-05-10 H.J. Lu <hongjiu.lu@intel.com>
+
PR ld/21481
* testsuite/ld-x86-64/pr21481a.c: New file.
* testsuite/ld-x86-64/pr21481b.S: Likewise.
diff --git a/ld/emulparams/i386lynx.sh b/ld/emulparams/i386lynx.sh
index 93afb3d..12bc7da 100644
--- a/ld/emulparams/i386lynx.sh
+++ b/ld/emulparams/i386lynx.sh
@@ -1,5 +1,6 @@
SCRIPT_NAME=elf
OUTPUT_FORMAT="elf32-i386"
+CHECK_RELOCS_AFTER_OPEN_INPUT=yes
NO_RELA_RELOCS=yes
ENTRY=_main
TEXT_BASE=0x0
diff --git a/ld/emulparams/i386moss.sh b/ld/emulparams/i386moss.sh
index 095d85a..bffef86 100644
--- a/ld/emulparams/i386moss.sh
+++ b/ld/emulparams/i386moss.sh
@@ -1,5 +1,6 @@
SCRIPT_NAME=elf
OUTPUT_FORMAT="elf32-i386"
+CHECK_RELOCS_AFTER_OPEN_INPUT=yes
NO_RELA_RELOCS=yes
TEXT_START_ADDR=0x00002000
MAXPAGESIZE="CONSTANT (MAXPAGESIZE)"
diff --git a/ld/emulparams/i386nw.sh b/ld/emulparams/i386nw.sh
index e1897be..e6397f6 100644
--- a/ld/emulparams/i386nw.sh
+++ b/ld/emulparams/i386nw.sh
@@ -1,5 +1,6 @@
SCRIPT_NAME=nw
OUTPUT_FORMAT="elf32-i386"
+CHECK_RELOCS_AFTER_OPEN_INPUT=yes
TEXT_START_ADDR=0x08000000
MAXPAGESIZE="CONSTANT (MAXPAGESIZE)"
ARCH=i386