This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] [ARC] Object attributes.
- From: Nick Clifton <nickc at redhat dot com>
- To: Claudiu Zissulescu <Claudiu dot Zissulescu at synopsys dot com>, binutils at sourceware dot org
- Date: Tue, 9 May 2017 16:23:39 +0100
- Subject: Re: [PATCH] [ARC] Object attributes.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=nickc at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 69E935BECB
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 69E935BECB
- References: <1fb923f0-8096-fb43-e8dc-e3850b66b4e5@redhat.com> <1494341946-11834-1-git-send-email-claziss@synopsys.com>
Hi Claudiu,
Thanks for fixing the test failure. Unfortunately I failed to actually look
at the code in the patch whilst I was testing it, so I missed a few things.
Specifically:
> +/* Allocate and concatenate two strings. s1 can be NULL but not> + s2. s1 pointer is freed at end of this procedure. */> +> +static char *> +arc_stralloc (char * s1, const char * s2)
Couldn't you make use of libiberty's concat() function here ?
> + /* We cannot mix code for different CPUs. */
> + _bfd_error_handler
> + (_("error: %B: unable to merge CPU base attributes "
> + "with %B."),
> + obfd, ibfd);
It would probably be helpful to the user if the error message said
exactly which two CPU types are involved here.
(Similarly for other error messages in this function).
Cheers
Nick