This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] RISC-V: Fix disassemble for c.li, c.andi and c.addiw
- From: Palmer Dabbelt <palmer at dabbelt dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: binutils at sourceware dot org
- Cc: patches at groups dot riscv dot org
- Cc: kito dot cheng at gmail dot com
- Date: Thu, 04 May 2017 03:22:07 -0700 (PDT)
- Subject: Re: [PATCH] RISC-V: Fix disassemble for c.li, c.andi and c.addiw
- Authentication-results: sourceware.org; auth=none
On Thu, 04 May 2017 03:05:51 PDT (-0700), Nick Clifton wrote:
> Hi Palmer,
>
>> 2017-05-03 Kito Cheng <kito.cheng@gmail.com>
>>
>> * riscv-dis.c (print_insn_args): Handle 'Co' operands.
>
> Approved - please apply.
>
> Note - given that you are a maintainer for the RISC-V port, you can go
> ahead and apply patches like this without waiting for approval. (Although
> please do still post the patches to this list, just add [COMMIT] to the
> subject line). The rule is - if the patch only affects RISC-V specific
> code then go ahead and review/apply it yourself. If it affects other
> targets, or has the potential to affect them, then post the patch for
> review.
Thanks. I've been submitting all my patches before committing them because I've
found people have useful suggestions, but if the patch goes unanswered for more
than a day or two I just commit it anyway.
I'd kind of like to keep doing this, but if it's a burden then I'll just start
directly committing small patches. You're welcome to just say nothing and I'll
commit the patch after a bit -- anything I submit has made it through at least
one other RISC-V person.
I went ahead and committed this one -- I guess it was almost pathologically
trivial :).