This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] [WebAssembly] Skeleton support
- From: Nick Clifton <nickc at redhat dot com>
- To: Pip Cet <pipcet at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Mon, 27 Mar 2017 13:44:27 +0100
- Subject: Re: [PATCH] [WebAssembly] Skeleton support
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=nickc at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 18D48624D9
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 18D48624D9
- References: <CAOqdjBfO29Yc09f22B4u61E2cjSBwpya8=phePCAgHTdArTPYQ@mail.gmail.com> <6ba7849d-2475-587d-d4a9-6e67c7df550b@redhat.com> <CAOqdjBcbL8-_KwufBPb96V6d0hh_QT6Sx2-tdWXu==qbUpRRZg@mail.gmail.com> <CAOqdjBe7tcNjET4rrmkk7_iXuQguhHzsJ-Jd=AxQowefy1ysGA@mail.gmail.com> <CAOqdjBdk9E13b=k0nO99eMZWoaLiCap8ph36jCy0RyjHxCAdzg@mail.gmail.com>
Hi Pip,
> 2017-03-23 Pip Cet <pipcet@gmail.com>
>
> * wasm-module.c: New file to support WebAssembly modules.
> * wasm-module.h: New file to support WebAssembly modules.
> * doc/webassembly.texi: Start documenting wasm-module.c.
> * config.bfd: Add wasm_vec.
> * targets.c: Likewise.
> * configure.ac: Likewise.
> * Makefile.am: Add entries for wasm-module.c.
Approved and applied.
One comment I would make is that we prefer sentences inside
comments to have two spaces after the full stop. This helps
emacs's sentence parsing code. But this was not sufficiently
important to hold up approving the patch.
Cheers
Nick