This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 1/6] DWARF attrs: add delimiter
- From: Nick Clifton <nickc at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>, binutils at sourceware dot org
- Cc: Victor Leschuk <vleschuk at accesssoftek dot com>
- Date: Thu, 16 Feb 2017 10:59:10 +0000
- Subject: Re: [PATCH 1/6] DWARF attrs: add delimiter
- Authentication-results: sourceware.org; auth=none
- References: <148719947800.19826.950569475344047705.stgit@host1.jankratochvil.net>
Hi Jan,
> 2017-02-12 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * dwarf.c (display_block): Add parameter delimiter.
> (decode_location_expression): Update display_block callers.
> (read_and_display_attr_value): Add parameter delimiter.
> (read_and_display_attr, display_debug_macro): Update
> read_and_display_attr_value caller.
The patch looks good to me. But ... I would be happier if it included
a testcase to check the new functionality.
Cheers
Nick