This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 5/8] Remove magic numbers in m68k-dis.c:print_insn_arg

From: Alan Modra <amodra at gmail dot com>
To: Yao Qi <qiyaoltc at gmail dot com>
Cc: binutils at sourceware dot org, gdb-patches at sourceware dot org
Date: Thu, 12 Jan 2017 08:44:06 +1030
Subject: Re: [PATCH 5/8] Remove magic numbers in m68k-dis.c:print_insn_arg
Authentication-results: sourceware.org; auth=none
References: <1484051178-16013-1-git-send-email-yao.qi@linaro.org> <1484051178-16013-6-git-send-email-yao.qi@linaro.org>

On Tue, Jan 10, 2017 at 12:26:15PM +0000, Yao Qi wrote:
> 	* m68k-dis.c (enum print_insn_arg_error): New.
> 	(NEXTBYTE): Replace -3 with
> 	PRINT_INSN_ARG_MEMORY_ERROR.
> 	(NEXTULONG): Likewise.
> 	(NEXTSINGLE): Likewise.
> 	(NEXTDOUBLE): Likewise.
> 	(NEXTDOUBLE): Likewise.
> 	(NEXTPACKED): Likewise.
> 	(FETCH_DATA): Update comments.
> 	(print_insn_arg): Update comments. Replace magic numbers with
> 	enum.
> 	(match_insn_m68k): Likewise.

OK.

-- 
Alan Modra
Australia Development Lab, IBM

Follow-Ups:
- Re: [PATCH 5/8] Remove magic numbers in m68k-dis.c:print_insn_arg
  - From: Yao Qi

References:
- [PATCH 0/8] Handle memory error on disassemble
  - From: Yao Qi
- [PATCH 5/8] Remove magic numbers in m68k-dis.c:print_insn_arg
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]