This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[Committed] S/390: Issue error for overflowing relocs.
- From: Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- To: binutils at sourceware dot org
- Date: Sat, 7 Jan 2017 22:18:45 +0100
- Subject: [Committed] S/390: Issue error for overflowing relocs.
- Authentication-results: sourceware.org; auth=none
Building PIE executable from non-PIC code results in broken binaries.
With this patch the problem is detected at link-time.
Committed to head. Ok for 2.28 branch as well?
Bye,
-Andreas-
bfd/ChangeLog:
2017-01-07 Andreas Krebbel <krebbel@linux.vnet.ibm.com>
* elf64-s390.c (elf_s390_relocate_section): Issue error for
non-PLT relocs of shared libary symbol in exectuable.
---
bfd/elf64-s390.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/bfd/elf64-s390.c b/bfd/elf64-s390.c
index bbfcd2e..edc9b86 100644
--- a/bfd/elf64-s390.c
+++ b/bfd/elf64-s390.c
@@ -2701,6 +2701,18 @@ elf_s390_relocate_section (bfd *output_bfd,
case R_390_PC32:
case R_390_PC32DBL:
case R_390_PC64:
+ if (h != NULL
+ && bfd_link_pie (info)
+ && !h->def_regular)
+ {
+ _bfd_error_handler (_("%B: `%s' non-PLT reloc for symbol defined "
+ "in shared library and accessed "
+ "from executable "
+ "(rebuild file with -fPIC ?)"),
+ input_bfd, h->root.root.string);
+ bfd_set_error (bfd_error_bad_value);
+ return FALSE;
+ }
/* The target of these relocs are instruction operands
residing in read-only sections. We cannot emit a runtime
reloc for it. */
--
2.9.1