This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Check ld_compile return status
- From: Alan Modra <amodra at gmail dot com>
- To: binutils at sourceware dot org
- Date: Tue, 3 Jan 2017 23:10:06 +1030
- Subject: Check ld_compile return status
- Authentication-results: sourceware.org; auth=none
If the compiler failed to produce an object file, there isn't much
point in trying to link it.
* testsuite/lib/ld-lib.exp (run_ld_link_exec_tests): Do not
allow test to continue after compilation errors.
(run_cc_link_tests): Likewise.
diff --git a/ld/testsuite/lib/ld-lib.exp b/ld/testsuite/lib/ld-lib.exp
index f8d5ec6..5ca700b 100644
--- a/ld/testsuite/lib/ld-lib.exp
+++ b/ld/testsuite/lib/ld-lib.exp
@@ -1414,10 +1414,18 @@ proc run_ld_link_exec_tests { ldtests args } {
# incorrect section attributes and the assembler will warn
# them.
if { [ string match "c++" $lang ] } {
- ld_compile "$CXX -c $CXXFLAGS $cflags" $srcdir/$subdir/$src_file $objfile
+ set cmd "$CXX -c $CXXFLAGS $cflags"
} else {
- ld_compile "$CC -c $CFLAGS $cflags" $srcdir/$subdir/$src_file $objfile
+ set cmd "$CC -c $CFLAGS $cflags"
}
+ if ![ld_compile $cmd $srcdir/$subdir/$src_file $objfile] {
+ set failed 1
+ break
+ }
+ }
+ if { $failed != 0 } {
+ unresolved $testname
+ continue
}
if { [ string match "c++" $lang ] } {
@@ -1549,10 +1557,18 @@ proc run_cc_link_tests { ldtests } {
# incorrect section attributes and the assembler will warn
# them.
if { [ string match "c++" $lang ] } {
- ld_compile "$CXX -c $CXXFLAGS $cflags" $srcdir/$subdir/$src_file $objfile
+ set cmd "$CXX -c $CXXFLAGS $cflags"
} else {
- ld_compile "$CC -c $CFLAGS $cflags" $srcdir/$subdir/$src_file $objfile
+ set cmd "$CC -c $CFLAGS $cflags"
}
+ if ![ld_compile $cmd $srcdir/$subdir/$src_file $objfile] {
+ set failed 1
+ break
+ }
+ }
+ if { $failed != 0 } {
+ unresolved $testname
+ continue
}
# Clear error and warning counts.
--
Alan Modra
Australia Development Lab, IBM