This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][gold] Fix an internal error in the constructor of Target_arm.

> I think a much simpler fix is to move the code that initializes
> target1_reloc_ and target2_reloc_ from the constructor into
> Target_arm::do_select_as_default_target().

Also, the test case doesn't actually need the (empty) test script or a
objdump -- all we want to do is make sure the link succeeds.

I've committed your patch with modifications as follows. Thanks!

-cary


2016-12-19  Igor Kudrin  <ikudrin@accesssoftek.com>

gold/
        * arm.cc (Target_arm::Target_arm): Move initialization code ...
        (Target_arm::do_select_as_default_target): ... to here.
        * testsuite/Makefile.am (arm_target_lazy_init): New test case.
        * testsuite/Makefile.in: Regenerate.
        * testsuite/arm_target_lazy_init.s: New source file.
        * testsuite/arm_target_lazy_init.t: New linker script.

Attachment: arm-lazy-init.patch
Description: Binary data

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]