This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/9] Rework RISC-V relocations

From: Mike Frysinger <vapier at gentoo dot org>
To: Palmer Dabbelt <palmer at dabbelt dot com>
Cc: binutils at sourceware dot org, Andrew Waterman <andrew at sifive dot com>
Date: Fri, 16 Dec 2016 18:39:48 -0500
Subject: Re: [PATCH 3/9] Rework RISC-V relocations
Authentication-results: sourceware.org; auth=none
References: <mhng-17a85049-0370-4515-bb28-ae698e3be392@palmer-mbp2014> <1481775826-6577-4-git-send-email-palmer@dabbelt.com>

On 14 Dec 2016 20:23, Palmer Dabbelt wrote:
> +void
> +riscv_pre_output_hook (void)
> +{
> +  frchainS *frchP;

i don't think we normally use this naming style.  if the "p" means
pointer, then write it lower case instead of upper.

> +  asection *s;

should all of pointers in this func be const ?  at a glance, seems like
they should be.
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH 3/9] Rework RISC-V relocations
  - From: Palmer Dabbelt

References:
- RISC-V Fixes for 2.28
  - From: Palmer Dabbelt
- [PATCH 3/9] Rework RISC-V relocations
  - From: Palmer Dabbelt

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]