This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 03/19] PRU Binutils port
On Mon, Dec 05, 2016 at 10:42:18PM +0200, Dimitar Dimitrov wrote:
> + case EM_PRU:
> + {
> + switch (reloc_type)
> + {
> + case 42: /* R_PRU_DIFF8. */
> + case 43: /* R_PRU_DIFF16. */
> + case 44: /* R_PRU_DIFF32. */
> + /* Nothing to do - diff value already stored. */
> + return TRUE;
> + }
> + }
> +
No need to add code like this that does nothing.
> + /* The ELF output from TI's CGT may be considered the standard
> + ELF format for PRU. But it is not documented. To avoid issues
> + with linking between TI and GNU object files, we use private
> + relocation numbers. For a small embedded target like PRU this
> + should not be a big deal. */
Presumably the TI tools use EM_TI_PRU as you do. So in effect you
will have two incompatible ABIs using the same e_machine value. I
think this is a really bad idea.
--
Alan Modra
Australia Development Lab, IBM