Re: [PATCH v2 2/7] gas/arc: Replace short_insn flag with insn length field

[Graham Markall <graham dot markall at embecosm dot com>]

Hi Nick,

>> gas/ChangeLog:
>>
>> 	* config/tc-arc.c (struct arc_insn): Replace short_insn flag with
>> 	len field.
>> 	(apply_fixups): Update to use len field.
>> 	(emit_insn0): Simplify code, making use of len field.
>> 	(md_convert_frag): Update to use len field.
>> 	(assemble_insn): Update to use len field.
> 
> Approved - please apply.

Many thanks - entire series applied.

> 
>>    long limm;
>> -  bfd_boolean short_insn; /* Boolean value: TRUE if current insn is
>> -			     short.  */
>> +  int len;                /* Length of instruction in bytes.  */
> 
> Can the length be negative ?  If not then maybe "unsigned int" would be more appropriate.

I don't think it can be, so I changed this to "unsigned int" when applying.


>> gas/ChangeLog:
>>
>>     * testsuite/gas/arc/nps400-6.s: Change ldbit tests so that
>>     limm operands are out of the range of an s9, in order to fix
>>     the test.
>>     * testsuite/gas/arc/nps400-6.d: Updated to match new expected
>>     output.
>
> Approved - please apply.


Also applied - many thanks!



Graham.

Attachment: signature.asc
Description: OpenPGP digital signature