This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH, binutils/ARM] Remove legacy basepri_mask MRS/MSR special reg
- From: Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>
- To: binutils at sourceware dot org, Richard Earnshaw <richard dot earnshaw at arm dot com>, Nick Clifton <nickc at redhat dot com>, Alan Modra <amodra at gmail dot com>
- Date: Tue, 20 Sep 2016 18:57:59 +0100
- Subject: [PATCH, binutils/ARM] Remove legacy basepri_mask MRS/MSR special reg
- Authentication-results: sourceware.org; auth=none
Hi,
When support for Cortex-M was originally added, a mistake was made in the
assembler and BASEPRI_MASK was used as an MRS/MSR special register instead of
the correct BASEPRI_MAX. This was back in 2010/11 timeframe. The code was fixed
fairly quickly but the incorrect name was left in place. I think it is now time
for the incorrect name to be dropped.
ChangeLog entry is as follows:
*** gas/ChangeLog ***
2016-09-12 Thomas Preud'homme <thomas.preudhomme@arm.com>
* config/tc-arm.c (v7m_psrs): Remove BASEPRI_MASK MRS/MSR special
register and redundant basepri_max.
Is this ok for trunk?
Best regards,
Thomas
diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c
index c71060110a44f96fd50f328fa9763cb489385328..c74c9983b8f7cb0bf59dfd855e3ee784ee7a3b68 100644
--- a/gas/config/tc-arm.c
+++ b/gas/config/tc-arm.c
@@ -18813,7 +18813,6 @@ static const struct asm_psr v7m_psrs[] =
{"primask", 0x10}, {"PRIMASK", 0x10},
{"basepri", 0x11}, {"BASEPRI", 0x11},
{"basepri_max", 0x12}, {"BASEPRI_MAX", 0x12},
- {"basepri_max", 0x12}, {"BASEPRI_MASK", 0x12}, /* Typo, preserved for backwards compatibility. */
{"faultmask", 0x13}, {"FAULTMASK", 0x13},
{"control", 0x14}, {"CONTROL", 0x14},
{"msp_ns", 0x88}, {"MSP_NS", 0x88},