This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Mon, Oct 5, 2015 at 2:58 PM, Sriraman Tallam <tmsriram@google.com> wrote: > On Wed, Sep 9, 2015 at 4:01 PM, Sriraman Tallam <tmsriram@google.com> wrote: >> On Wed, Sep 2, 2015 at 4:32 PM, Sriraman Tallam <tmsriram@google.com> wrote: >>> >>> On Tue, Aug 18, 2015 at 9:46 PM, Cary Coutant <ccoutant@gmail.com> wrote: >>> >> Thanks, will make those changes. Do you recommend a different name >>> >> for this flag like -fmake-comdat-functions-static? >>> > >>> > Well, the C++ ABI refers to this as "vague linkage." It may be a bit >>> > too long or too ABI-specific, but maybe something like >>> > -f[no-]use-vague-linkage-for-functions or >>> > -f[no-]functions-vague-linkage? >>> >>> Done and patch attached. >> >> >> <Re-sending as plain text> >> Ping. Forgot to follow up on this one but is patch of for trunk? * c-family/c.opt (fvague-linkage-functions): New option. * cp/decl2.c (comdat_linkage): Implement new option. Warn when virtual comdat functions are seen. * ipa.c (function_and_variable_visibility): Check for no vague linkage. * doc/invoke.texi: Document new option. * testsuite/g++.dg/no-vague-linkage-functions-1.C: New test. Thanks Sri > > Ping. > > >> >> * c-family/c.opt (fvague-linkage-functions): New option. >> * cp/decl2.c (comdat_linkage): Implement new option. Warn when >> virtual comdat functions are seen. >> * ipa.c (function_and_variable_visibility): Check for no vague >> linkage. >> * doc/invoke.texi: Document new option. >> * testsuite/g++.dg/no-vague-linkage-functions-1.C: New test. >> >>> >>> >>> * c-family/c.opt (fvague-linkage-functions): New option. >>> * cp/decl2.c (comdat_linkage): Implement new option. Warn when >>> virtual comdat functions are seen. >>> * ipa.c (function_and_variable_visibility): Check for no vague >>> linkage. >>> * doc/invoke.texi: Document new option. >>> * testsuite/g++.dg/no-vague-linkage-functions-1.C: New test. >>> >>> >>> >>> >>> > >>> > And perhaps note in the doc that using this option may technically >>> > break the C++ ODR, so it should be used only when you know what you're >>> > doing. >>> >>> Done. >>> >>> Thanks >>> Sri >>> >>> > >>> > -cary
Attachment:
no_vague_linkage_functions.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |