This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Fix duplicate FAILs from ld testsuite
- From: Alan Modra <amodra at gmail dot com>
- To: binutils at sourceware dot org
- Date: Tue, 23 Aug 2016 13:59:12 +0930
- Subject: Fix duplicate FAILs from ld testsuite
- Authentication-results: sourceware.org; auth=none
Applied.
* testsuite/lib/ld-lib.exp (run_cc_link_tests): Don't fail tests
twice.
diff --git a/ld/testsuite/lib/ld-lib.exp b/ld/testsuite/lib/ld-lib.exp
index 7b190be..616ac51 100644
--- a/ld/testsuite/lib/ld-lib.exp
+++ b/ld/testsuite/lib/ld-lib.exp
@@ -1588,7 +1588,6 @@ proc run_cc_link_tests { ldtests } {
# compile only
} elseif { [regexp ".*\\.a$" $binfile] } {
if { ![ar_simple_create $ar $ldflags $binfile "$objfiles"] } {
- fail $testname
set failed 1
}
} else {
@@ -1605,10 +1604,6 @@ proc run_cc_link_tests { ldtests } {
set failed 1
}
}
-
- if { $failed == 1 } {
- fail $testname
- }
}
if { $failed == 0 } {
@@ -1669,13 +1664,12 @@ proc run_cc_link_tests { ldtests } {
}
}
- if { $failed != 0 } {
+ if { $failed } {
fail $testname
- } elseif { $is_unresolved == 0 } {
- pass $testname
- } else {
+ } elseif { $is_unresolved } {
unresolved $testname
- continue
+ } else {
+ pass $testname
}
}
}
--
Alan Modra
Australia Development Lab, IBM