Re: [PATCH] PR ld/20283: gold: Add a linker configure option --enable-relro

[Mike Frysinger <vapier at gentoo dot org>]

On 21 Jun 2016 15:11, H.J. Lu wrote:
> +# Decide if -z relro should be enabled in ELF linker by default.
> +ac_default_ld_z_relro=unset
> +# Provide a configure time option to override our default.
> +AC_ARG_ENABLE(relro,
> +	      AS_HELP_STRING([--enable-relro],
> +	      [enable -z relro in ELF linker by default]),
> +[case "${enableval}" in
> +  no)  ac_default_ld_z_relro=0 ;;
> +esac])dnl
> +if test ${ac_default_ld_z_relro} = unset; then
> +  ac_default_ld_z_relro=1
> +fi

not that it's a new thing, but that expansion should really be quoted.

any reason to not just write it like:
AC_ARG_ENABLE(relro,
	AS_HELP_STRING([--enable-relro],
		[enable -z relro in ELF linker by default]))
if test "${enable_relro}" = "yes"; then
  ac_default_ld_z_relro=1
else
  ac_default_ld_z_relro=0
fi

it's a bit simpler that way.
-mike

Attachment: signature.asc
Description: Digital signature