This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH v2 1/3] [ARC] Add arithmetic and logic instructions for nps
- From: Nick Clifton <nickc at redhat dot com>
- To: Graham Markall <graham dot markall at embecosm dot com>, binutils at sourceware dot org
- Cc: Claudiu Zissulescu <Claudiu dot Zissulescu at synopsys dot com>
- Date: Tue, 14 Jun 2016 14:19:41 +0100
- Subject: Re: [PATCH v2 1/3] [ARC] Add arithmetic and logic instructions for nps
- Authentication-results: sourceware.org; auth=none
- References: <2c59857dfcfc0b31c69d0f3e2a91ca1ad6720a3b dot 1465827288 dot git dot graham dot markall at embecosm dot com> <1465909998-13088-1-git-send-email-graham dot markall at embecosm dot com>
Hi Graham,
A small point:
> +#define MAKE_1BASED_INSERT_EXTRACT_FUNCS(NAME,SHIFT,UPPER,BITS) \
> +static unsigned \
> +insert_nps_##NAME (unsigned insn ATTRIBUTE_UNUSED, \
> + int value ATTRIBUTE_UNUSED, \
> + const char **errmsg ATTRIBUTE_UNUSED) \
> +{ \
> + if (value < 1 || value > UPPER) \
> + *errmsg = _("Value must be in the range 0 to " #UPPER); \
If value is zero then the error message will be triggered, but the message
says that zero is a permissible value...
Cheers
Nick