This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: add vulcan support to gas

From: Virendra Pathak <virendra dot pathak at broadcom dot com>
To: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
Cc: Syed Faisal Akber <faisal at akber dot net>, "binutils at sourceware dot org" <binutils at sourceware dot org>, Virendra Kumar Pathak <kumarvir dot pathak at gmail dot com>, nickc at redhat dot com
Date: Thu, 9 Jun 2016 14:24:37 +0530
Subject: Re: add vulcan support to gas
Authentication-results: sourceware.org; auth=none
References: <CANx+fTAsJtE27XTwVV8Cx9mZT4Nwn4eotTRNB1wf3yU0xqR5Mw at mail dot gmail dot com> <20160607131026 dot 5525587 dot 57372 dot 96006 at akber dot net> <CAFqB+PzaheoB1UoHhT_1he7BrUXYFsoHHTtb7B3=ibWeK4kd4w at mail dot gmail dot com> <CANx+fTAZ2KfMO5JkMhUDjcMyY1190mW4PtBySggUO9XN_9AzGQ at mail dot gmail dot com> <CAFqB+Pw4V+Ho92qr5+2J3CG=Fd15u90-bM0tJp3yG4ytUuAeNg at mail dot gmail dot com>

Hi Marcus,

Thanks for the review.
Please find the updated patch (attached with this mail) with vulcan
name in alphabetical order.
Also fixed the ChangeLog. Please review it.

gas/ChangeLog:

Virendra Pathak <virendra.pathak@broadcom.com>

        * config/tc-aarch64.c (aarch64_cpus): Add vulcan.
        * doc/c-aarch64.texi: Document that vulcan is a valid processor name.



Thanks.

with regards,
Virendra Pathak


On Wed, Jun 8, 2016 at 1:29 PM, Marcus Shawcroft
<marcus.shawcroft@gmail.com> wrote:
> On 8 June 2016 at 06:35, Virendra Pathak <virendra.pathak@broadcom.com> wrote:
>> Hi Marcus,
>>
>> 1) I have attached the binutils patch in the first mail
>
> Hi,
>
> Thanks for the patch, I have a couple of minor comments:
>
>
> +  {"vulcan", AARCH64_FEATURE (AARCH64_ARCH_V8,
> +                              AARCH64_FEATURE_CRC | AARCH64_FEATURE_CRYPTO),
> +  "Broadcom Vulcan"},
>    {"thunderx", AARCH64_FEATURE (AARCH64_ARCH_V8,
>
> Please add vulcan in alphabetical order.
>
>  @code{qdf24xx},
> +@code{vulcan},
>  @code{thunderx},
>
> Likewise.
>
>> 2) Added the author entry in the ChangeLog
>>
>> gas/ChangeLog:
>> Virendra Pathak (virendra.pathak@broadcom.com)
>> * config/tc-aarch64.c (aarch64_cpus): Add vulcan.
>
>> * doc/c-aarch64.texi : Document that vulcan is a valid processor name
>
> No space between before the ':', full stop at the end of the sentence.
>
> Thanks
> /Marcus

Attachment: 0001-aarch64-add-vulcan-support-to-gas.patch.txt
Description: Text document

Follow-Ups:
- Re: add vulcan support to gas
  - From: Nick Clifton

References:
- add vulcan support to gas
  - From: Virendra Pathak
- Re: add vulcan support to gas
  - From: Syed Faisal Akber
- Re: add vulcan support to gas
  - From: Marcus Shawcroft
- Re: add vulcan support to gas
  - From: Virendra Pathak
- Re: add vulcan support to gas
  - From: Marcus Shawcroft

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]