This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] make the type of nds32_pseudo_opcode::pseudo_val unsigned
- From: Nick Clifton <nickc at redhat dot com>
- To: tbsaunde+binutils at tbsaunde dot org, binutils at sourceware dot org
- Date: Mon, 23 May 2016 16:50:21 +0100
- Subject: Re: [PATCH] make the type of nds32_pseudo_opcode::pseudo_val unsigned
- Authentication-results: sourceware.org; auth=none
- References: <1463989223-7495-1-git-send-email-tbsaunde+binutils at tbsaunde dot org>
Hi Trev,
> built and regtested nds32be-elf, ok?
Not sure...
> @@ -2106,7 +2106,7 @@ struct nds32_pseudo_opcode
> const char *opcode;
> int argc;
> nds32_pseudo_opcode_func proc;
> - int pseudo_val;
> + unsigned int pseudo_val;
>
I think that you ought to change the type of the pv parameter of the
nds32_pseudo_opcode_func as well, and then trickle the change down into
the pseudo functions as well. Ie be consistent in the type of this
variable.
Cheers
Nick