This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH] Add support for MIPS DSPr3
- From: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- To: Maciej Rozycki <Maciej dot Rozycki at imgtec dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Wed, 11 May 2016 08:27:23 +0000
- Subject: RE: [PATCH] Add support for MIPS DSPr3
- Authentication-results: sourceware.org; auth=none
- References: <6D39441BF12EF246A7ABCE6654B023537E403E42 at hhmail02 dot hh dot imgtec dot org> <alpine dot DEB dot 2 dot 00 dot 1605101714330 dot 6794 at tp dot orcam dot me dot uk> <6D39441BF12EF246A7ABCE6654B023537E40517E at hhmail02 dot hh dot imgtec dot org> <alpine dot DEB dot 2 dot 00 dot 1605102321130 dot 6794 at tp dot orcam dot me dot uk>
Maciej Rozycki <Maciej.Rozycki@imgtec.com> writes:
> On Tue, 10 May 2016, Matthew Fortune wrote:
>
> > > Thank you for your contribution. Your change looks good overall, except
> > > for a minor nit, see below. However it adds new command-line options, so
> > > a corresponding GAS manual update is required. Please resubmit with these
> > > changes made.
> >
> > Thanks, docs for command line and directives added.
>
> Thanks, please update gas/doc/as.texinfo too, both the option summary and
> option details. You can reuse the relevant part of gas/doc/c-mips.texi
> for the latter. Remember to adjust the ChangeLog entry accordingly.
Oops, rusty with gas submissions.
> > diff --git a/gas/doc/c-mips.texi b/gas/doc/c-mips.texi
> > index 30544db..0b16e08 100644
> > --- a/gas/doc/c-mips.texi
> > +++ b/gas/doc/c-mips.texi
> > @@ -191,6 +191,13 @@ This option implies -mdsp.
> > This tells the assembler to accept DSP Release 2 instructions.
> > @samp{-mno-dspr2} turns off this option.
> >
> > +@item -mdspr3
> > +@itemx -mno-dspr3
> > +Generate code for the DSP Release 3 Application Specific Extension.
> > +This option implies -mdsp and -mdspr2.
>
> Please use @samp{} here too (and then in gas/doc/as.texinfo of course).
I mirrored the formatting in -mdspr2 so I have updated -mdspr2 docs as
well to use @samp on the implied options.
> OK to apply with these updates, thanks for your work.
I've done all the tabs/spaces in the test file. Without a whole testsuite
update there is very little to use as a definitive best practice example
so I expect most testsuite changes will suffer these issues.
Thanks,
Matthew