This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Enable Intel RDPID instruction.
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Alexander Fomin <afomin dot mailbox at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Tue, 10 May 2016 06:52:40 -0700
- Subject: Re: [PATCH] Enable Intel RDPID instruction.
- Authentication-results: sourceware.org; auth=none
- References: <20160503102646 dot GA26920 at msticlxl57 dot ims dot intel dot com> <CAMe9rOo4sCy3b3ttNi+K2Nrz6+4OxiHKaMhOCnZ9ejPxi3PDTg at mail dot gmail dot com> <CAMe9rOquSZXPCEcAJqnwJEcwP7qJ9u+AV0qgFxHBoWaMwZOJXg at mail dot gmail dot com> <20160510120254 dot GA50622 at msticlxl57 dot ims dot intel dot com> <CAMe9rOrN_jvQbi4yvU3q+rXAMdov+tw=CEhriKw9mp8+Pcq=tQ at mail dot gmail dot com> <20160510124237 dot GA54162 at msticlxl57 dot ims dot intel dot com> <CAMe9rOqNc89cwkj0TbK0LRiZzRRte+4_aqzZacRSH=SkO+PQ_Q at mail dot gmail dot com> <20160510132408 dot GA50728 at msticlxl57 dot ims dot intel dot com>
On Tue, May 10, 2016 at 6:24 AM, Alexander Fomin
<afomin.mailbox@gmail.com> wrote:
> On Tue, May 10, 2016 at 06:15:32AM -0700, H.J. Lu wrote:
>> On Tue, May 10, 2016 at 5:42 AM, Alexander Fomin
>> <afomin.mailbox@gmail.com> wrote:
>>
>> >> >
>> >> > Here is an updated version now that we've clarified REX.W behavior.
>> >>
>> >> It is OK. Please check it in.
>> >
>> > Thanks.
>> > I've just realized that my patch lacks RDPID entry in cpu_arch array
>> > (gas/config/tc-i386.c); may I check it in without re-submitting the
>> > patch to ML w/ corresponding ChangeLog entry?
>> >
>>
>> Please post the patch here. I will take a quick look.
>>
>>
>> --
>> H.J.
>
> Here is what I want to add (w/ already approved parts skipped).
>
> Alexander
> --
> gas/
>
> * config/tc-i386.c (cpu_arch): Add RDPID.
> ---
> gas/config/tc-i386.c | 2 +
>
> diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c
> index f382a73..2aeaf7b 100644
> --- a/gas/config/tc-i386.c
> +++ b/gas/config/tc-i386.c
> @@ -961,6 +961,8 @@ static const arch_entry cpu_arch[] =
> CPU_MWAITX_FLAGS, 0, 0 },
> { STRING_COMMA_LEN (".ospke"), PROCESSOR_UNKNOWN,
> CPU_OSPKE_FLAGS, 0, 0 },
> + { STRING_COMMA_LEN (".rdpid"), PROCESSOR_UNKNOWN,
> + CPU_RDPID_FLAGS, 0, 0 },
> };
>
> #ifdef I386COFF
> --
> 1.8.3.1
>
It is OK. Thanks.
--
H.J.