This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 2/4] Add support for .extInstruction pseudo-op.
- From: Nick Clifton <nickc at redhat dot com>
- To: Claudiu Zissulescu <Claudiu dot Zissulescu at synopsys dot com>, binutils at sourceware dot org
- Date: Mon, 11 Apr 2016 14:48:22 +0100
- Subject: Re: [PATCH 2/4] Add support for .extInstruction pseudo-op.
- Authentication-results: sourceware.org; auth=none
- References: <1460368239-7577-1-git-send-email-claziss at synopsys dot com> <1460368239-7577-2-git-send-email-claziss at synopsys dot com>
Hi Claudiu,
Approved - please apply, but ...
> +static void tokenize_extinsn (extInstruction_t *einsn)
Please place the function name at the start of its own line.
> +static void arc_extinsn (int ignore ATTRIBUTE_UNUSED)
Likewise.
Cheers
Nick