This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH] [ARC] Fix support for double assist instructions.
- From: Claudiu Zissulescu <Claudiu dot Zissulescu at synopsys dot com>
- To: Nick Clifton <nickc at redhat dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Cc: "Francois dot Bedard at synopsys dot com" <Francois dot Bedard at synopsys dot com>
- Date: Tue, 5 Apr 2016 15:42:14 +0000
- Subject: RE: [PATCH] [ARC] Fix support for double assist instructions.
- Authentication-results: sourceware.org; auth=none
- References: <1459784039-32010-1-git-send-email-claziss at synopsys dot com> <5703C8F0 dot 5090506 at redhat dot com>
Hi Nick,
I've fixed the indicated issues. I also observed that there are more alike issues in gas. I will prepare a patch to fix them as well.
Thank you for your review, patch committed.
Claudiu
> > + else
> > + as_warn ("Code density option invalid for selected CPU");
>
> Please could you place text messages like this inside _(...), as in:
>
> as_warn (_("Code density option invalid for selected CPU"));
>
> This allows the message to be translated into other languages.
>
>
> > + as_warn ("FPUDA invalid for selected CPU");
>
> Likewise here.
>
> Approved with those changes.
>
> Cheers
> Nick