This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] gas: sparc: allow ASR registers in the 0..31 range in V9 and later
- From: Nick Clifton <nickc at redhat dot com>
- To: "Jose E. Marchesi" <jose dot marchesi at oracle dot com>, binutils at sourceware dot org
- Date: Thu, 24 Mar 2016 10:44:47 +0000
- Subject: Re: [PATCH] gas: sparc: allow ASR registers in the 0..31 range in V9 and later
- Authentication-results: sourceware.org; auth=none
- References: <8760we44lk dot fsf at oracle dot com>
hi Jose,
> + * config/tc-sparc.c (sparc_ip): Remove the V9 restriction on ASR
> + registers to be in the 16..31 range.
Approved - please apply, but...
> + if (num < 0 || 31 < num)
> + {
> + error_message = _(": asr number must be between 0 and 31");
> + goto error;
> + }
Please could you add a comment here, explaining the rationale that you
mentioned in your email. That way a reader of the sources who wonders
why the assembler is not complaining about "invalid" asr names, will
know what is going on.
Cheers
Nick