This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Fix shift left warning at source
- From: Alan Modra <amodra at gmail dot com>
- To: binutils at sourceware dot org
- Date: Wed, 2 Mar 2016 13:41:58 +1030
- Subject: Fix shift left warning at source
- Authentication-results: sourceware.org; auth=none
Nick's fix to fr30-ibld.c disappears when regenerating cgen files.
cpu/
* fr30.cpu (f-m4): Replace -1 << 4 with -16.
opcodes/
* fr30-ibld.c: Regenerate.
diff --git a/cpu/fr30.cpu b/cpu/fr30.cpu
index 6c8e8ce..0124647 100644
--- a/cpu/fr30.cpu
+++ b/cpu/fr30.cpu
@@ -163,7 +163,7 @@
; ??? On a 64 bit host this doesn't get completely sign extended
; if the value is recorded in a long, as it is during extraction.
; Various fixes exist, pick one.
- ((value pc) (or WI value (sll WI (const -1) (const 4))))
+ ((value pc) (or WI value (const -16)))
)
(dnf f-u8 "8 bit unsigned" () 8 8)
(dnf f-i8 "8 bit unsigned" () 4 8)
diff --git a/opcodes/fr30-ibld.c b/opcodes/fr30-ibld.c
index 1293e73..3ebecf9 100644
--- a/opcodes/fr30-ibld.c
+++ b/opcodes/fr30-ibld.c
@@ -881,7 +881,7 @@ fr30_cgen_extract_operand (CGEN_CPU_DESC cd,
{
long value;
length = extract_normal (cd, ex_info, insn_value, 0, 0, 8, 4, 16, total_length, pc, & value);
- value = ((value) | (((-1UL) << (4))));
+ value = ((value) | (-16));
fields->f_m4 = value;
}
break;
--
2.1.0
--
Alan Modra
Australia Development Lab, IBM