This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: linker plugin api limitation

I've sent the fix (get_symbols() returning LDPS_NO_SYMS) to the ML
recently, but it looks like this is only part of the problem.

I've filed with a test
case for a similar problem where gold incorrectly decides to include
an input file in the link (and fails even before the first
get_symbols() call). I'm not sure what's going on at this point.

On Tue, Feb 23, 2016 at 5:35 AM, Rafael EspÃndola
<> wrote:
>> I think I'd prefer to have get_input_file() return a new status code
>> (or maybe LDPS_NO_SYMS). But I don't think that interface is used in
>> the LTO plugin, and I can see not wanting to call get_input_file() and
>> release_input_file() in cases where the plugin didn't have to call it
>> before.
> It is used (at least on the llvm side) to get the filesize and name
> fields, so yes, having it return  LDPS_NO_SYMS or a new code should
> work.
>> So I'd be OK with adding either a new status return for get_symbols()
>> or a new symbol resolution value to replace LDPR_PREEMPTED_REG for
>> this case. Either one will warrant a "V3".
>> I guess I'd lean towards having get_symbols() just return LDPS_NO_SYMS
>> for this case.
> Cheers,
> Rafael

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]