This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Commit: Fix
- From: Nick Clifton <nickc at redhat dot com>
- To: binutils at sourceware dot org
- Date: Mon, 08 Feb 2016 14:50:50 +0000
- Subject: Commit: Fix
- Authentication-results: sourceware.org; auth=none
Hi Guys,
I am applying the patch below to fix this compile time warning from
newer versions of gcc:
gas/config/tc-ia64.c: In function 'dot_prologue':
gas/config/tc-ia64.c:4363:2: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation]
n = popcount (mask);
gas/config/tc-ia64.c:4361:7: note: ...this 'else' clause, but it is not
else
It turns out that the warning is correct, the programmer probably did
intend for the else clause to guard the calculation. But it is safer
to always compute n, even if the mask is zero, so I have left the code
the way it was, just with the formatting fixed.
Cheers
Nick
gas/ChangeLog
2016-02-08 Nick Clifton <nickc@redhat.com>
* config/tc-ia64.c (dot_prologue): Fix formatting.
diff --git a/gas/config/tc-ia64.c b/gas/config/tc-ia64.c
index 570f746..e00b8e1 100644
--- a/gas/config/tc-ia64.c
+++ b/gas/config/tc-ia64.c
@@ -4360,7 +4360,8 @@ dot_prologue (int dummy ATTRIBUTE_UNUSED)
as_warn (_("Pointless use of zero first operand to .prologue"));
else
mask = e.X_add_number;
- n = popcount (mask);
+
+ n = popcount (mask);
if (sep == ',')
parse_operand_and_eval (&e, 0);