This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold commit] PR 19577: Fix build failure in gold due to signed vs. unsigned comparisons
- From: Cary Coutant <ccoutant at gmail dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Sat, 6 Feb 2016 10:24:32 -0800
- Subject: Re: [gold commit] PR 19577: Fix build failure in gold due to signed vs. unsigned comparisons
- Authentication-results: sourceware.org; auth=none
- References: <CAJimCsGtSKEG2vNmtfTsVec=apHDaFYRrFvh7pn7tuzfrW4+cw at mail dot gmail dot com> <871t8p678v dot fsf at linux-m68k dot org>
>> - int32_t max = static_cast<int32_t>((1U << bits) - 1);
>> + uint32_t max = static_cast<int32_t>((1U << bits) - 1);
>
> Shouldn't the cast be changed as well?
>> - int64_t max = static_cast<int64_t>((static_cast<uint64_t>(1) << bits) - 1);
>> + uint64_t max = static_cast<int64_t>((static_cast<uint64_t>(1) <<
>> bits) - 1);
>
> Here the cast doesn't make sense any more.
Oops, yes. Thanks. (I blame it on Saturday morning.)
-cary