This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 2/4] gold: Correctly get and put r_info for Mips64el.

From: Cary Coutant <ccoutant at gmail dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: Vladimir Radosavljevic <Vladimir dot Radosavljevic at imgtec dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>, Petar Jovanovic <Petar dot Jovanovic at imgtec dot com>
Date: Tue, 12 Jan 2016 11:42:16 -0800
Subject: Re: [PATCH v2 2/4] gold: Correctly get and put r_info for Mips64el.
Authentication-results: sourceware.org; auth=none
References: <3060420525346945A0ADBD567348A91723737257 at BADAG02 dot ba dot imgtec dot org> <CAJimCsFogsVm1t6zjzsP_Es4vjnXHMzjG3RnGZ_zy7VtDLk+qQ at mail dot gmail dot com> <CAMe9rOpHdTG7jyM33jKnnXeOMF2mw+OE-Q9P0KJB7-0basiPQw at mail dot gmail dot com> <CAMe9rOqYTABq9kMdNRagON3wbFE=mZk5AVwuiDxDWFS+vXJgdg at mail dot gmail dot com>

>> It breaks i686 gold:
>>
>> gcctestdir/ld: internal error in get_reloc_addend, at
>> /export/gnu/import/git/sources/binutils-gdb/gold/reloc-types.h:49
>> collect2: error: ld returned 1 exit status
>> Makefile:5149: recipe for target 'icf_virtual_function_folding_test' failed
>> make[7]: *** [icf_virtual_function_folding_test] Error 1
>>
>
> It breaks all REL targets.

Sorry for the breakage, and thanks for the quick analysis.

I've pushed the attached patch:

2016-01-12  Cary Coutant  <ccoutant@gmail.com>

gold/
        * arm.cc (Target_arm::Classify_reloc::get_r_addend): New method.
        * i386.cc (Target_i386::Classify_reloc::get_r_addend): New method.
        * mips.cc (Target_arm::Mips_classify_reloc::get_r_addend): (Both
        specializations) New method.

-cary

Attachment: get_r_addend.patch
Description: Binary data

Follow-Ups:
- Re: [PATCH v2 2/4] gold: Correctly get and put r_info for Mips64el.
  - From: H.J. Lu

References:
- Re: [PATCH v2 2/4] gold: Correctly get and put r_info for Mips64el.
  - From: Cary Coutant
- Re: [PATCH v2 2/4] gold: Correctly get and put r_info for Mips64el.
  - From: H.J. Lu
- Re: [PATCH v2 2/4] gold: Correctly get and put r_info for Mips64el.
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]