This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] ARM: Add support for thumb1 PCROP relocations.
- From: Nick Clifton <nickc at redhat dot com>
- To: mickael guene <mickael dot guene at st dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Tue, 1 Dec 2015 14:29:49 +0000
- Subject: Re: [PATCH] ARM: Add support for thumb1 PCROP relocations.
- Authentication-results: sourceware.org; auth=none
- References: <5652D1AE dot 1030207 at st dot com> <alpine dot DEB dot 2 dot 10 dot 1511231039160 dot 5401 at digraph dot polyomino dot org dot uk> <565307C0 dot 8070802 at st dot com> <56584FE2 dot 1010603 at redhat dot com> <565C0F2E dot 40400 at st dot com>
Hi Mickael,
I understand your point. On the other side, ARM has released
compilers with these relocations implemented, so modifications are
unlikely.
OK, well that is good to know.
Anyway, is it possible to have feedback about the patch by itself ?
This will allow for quick upstream when the document is officially
released.
Certainly. The patch itself looks fine to me apart from a few, minor,
formatting issues:
+ /* compute address. */
Comments should be treated as sentences, so they should start with a
capital letter.
+ /* The following conditions must be true :
+ * - ADD
+ * - Rd == Rs
+ * - Rd <= 7
+ */
Multi-line comments should not have asterisk prefixes.
+ } else {
Curly braces should be on their own on a line.
+ as_bad_where (fixP->fx_file, fixP->fx_line,
+ "Unable to process relocation for thumb opcode: %lx",
+ (unsigned long) insn);
Strings for error messages should be enclosed in _(.....) so that they
can be translated.
+ RELOC_NUMBER (R_ARM_THM_ALU_ABS_G0_NC,132)
What happened to relocs number 130 and 131 ? [Just curious...]
Cheers
Nick