This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] add a configure option for using RELRO by default

From: Mike Frysinger <vapier at gentoo dot org>
To: Romain Geissler <romain dot geissler at amadeus dot com>
Cc: binutils at sourceware dot org, schwab at suse dot de, hjl dot tools at gmail dot com, danielmicay at gmail dot com
Date: Tue, 10 Nov 2015 18:28:22 -0500
Subject: Re: [PATCH] add a configure option for using RELRO by default
Authentication-results: sourceware.org; auth=none
References: <alpine dot LNX dot 2 dot 10 dot 1509191709291 dot 15470 at ncegcolnx273 dot nce dot amadeus dot net> <alpine dot LNX dot 2 dot 10 dot 1511102205590 dot 31735 at ncegcolnx273 dot nce dot amadeus dot net>

On 10 Nov 2015 22:16, Romain Geissler wrote:
> --- a/gold/configure.ac
> +++ b/gold/configure.ac
>
> +# Decide whether you want to set "-z relro" by default

should be a dnl instead of a # ?

> +ac_default_relro=unset

i don't think we want the ac_ prefix since this isn't autoconf code.

would be better too imo to make this the 4th arg to AC_ARG_ENABLE below.

> +  *) AC_MSG_ERROR(bad value ${enableval} for default-relro option) ;;

should quote the arg with []

> +if test x$ac_default_relro == xyes ; then

quote the LHS and change the == to =

> +  AC_DEFINE(DEFAULT_RELRO, 1, [Define if you want to use read only relocations by default])

quote the 1st & 2nd arg with []

> +#ifdef DEFAULT_RELRO
> +#define DEFAULT_RELRO_VALUE true
> +#else
> +#define DEFAULT_RELRO_VALUE false
> +#endif

should use "# define" imo

> --- a/ld/configure.ac
> +++ b/ld/configure.ac

same feedback here as for gold
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH] add a configure option for using RELRO by default
  - From: Romain Geissler

References:
- Re: [PATCH] add a configure option for using RELRO by default
  - From: Romain Geissler

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]