This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 2/3] [aarch64] expose disas_aarch64_insn and rename it to aarch64_decode_insn
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Fri, 2 Oct 2015 13:35:11 +0100
- Subject: Re: [PATCH 2/3] [aarch64] expose disas_aarch64_insn and rename it to aarch64_decode_insn
- Authentication-results: sourceware.org; auth=none
- References: <CAFqB+Px8-V8eojj8T66_zrM6krPeGXBVLU9h+_j5yEcrk0MMJg at mail dot gmail dot com> <1443785039-24602-1-git-send-email-yao dot qi at linaro dot org> <1443785039-24602-3-git-send-email-yao dot qi at linaro dot org>
On 2 October 2015 at 12:23, Yao Qi <qiyaoltc@gmail.com> wrote:
> include/opcode:
>
> 2015-10-02 Yao Qi <yao.qi@linaro.org>
>
> * aarch64.h (aarch64_decode_insn): Declare it.
>
> opcodes:
>
> 2015-10-02 Yao Qi <yao.qi@linaro.org>
>
> * aarch64-dis.c (disas_aarch64_insn): Remove static. Change
> argument insn type to aarch64_insn. Rename to ...
> (aarch64_decode_insn): ... it.
> (print_insn_aarch64_word): Caller updated.
> ---
> include/opcode/aarch64.h | 3 +++
> opcodes/aarch64-dis.c | 9 +++++----
> 2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h
> index dcf0fef..d0c7489 100644
> --- a/include/opcode/aarch64.h
> +++ b/include/opcode/aarch64.h
> @@ -925,6 +925,9 @@ aarch64_stack_pointer_p (const aarch64_opnd_info *);
> extern
> int aarch64_zero_register_p (const aarch64_opnd_info *);
>
> +extern
> +int aarch64_decode_insn (aarch64_insn, aarch64_inst *);
The usual layout would be:
extern int
aarch64_decode_insn (....
OK with that change.
/Marcus