This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[gold commit] PR 18866: Fix regression introduced by fix for PR 18703

From: Cary Coutant <ccoutant at gmail dot com>
To: Binutils <binutils at sourceware dot org>
Date: Tue, 25 Aug 2015 17:54:51 -0700
Subject: [gold commit] PR 18866: Fix regression introduced by fix for PR 18703
Authentication-results: sourceware.org; auth=none

When a user object overrides a versioned definition in a shared object,
it's possible to trigger an internal error because the versioned
definition we saw didn't override the unversioned definition. This
was introduced by the fix for PR 18703. This patch fixes the problem
by reordering the tests so that we do not check ret->is_default()
until we're confident that the symbol is in fact versioned.

-cary


2015-08-25  Cary Coutant  <ccoutant@gmail.com>

gold/
        PR gold/18866
        PR gold/18703
        * symtab.cc (Symbol_table): Reorder conditions to avoid internal error.

Attachment: pr18866.patch
Description: Binary data

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]