This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[AArch64][8/8] LD support BFD_RELOC_AARCH64_TLSLD_ADD_DTPREL_LO12
- From: Jiong Wang <jiong dot wang at arm dot com>
- To: "binutils\ at sourceware dot org" <binutils at sourceware dot org>
- Date: Fri, 24 Jul 2015 17:03:53 +0100
- Subject: [AArch64][8/8] LD support BFD_RELOC_AARCH64_TLSLD_ADD_DTPREL_LO12
- Authentication-results: sourceware.org; auth=none
This patch add BFD support for BFD_RELOC_AARCH64_TLSLD_ADD_DTPREL_LO12.
Note, this relocation does not go through GOT table, it's relocation
against the offset to local module TLS base address, and we must do
overflow check. I found we have some other TLS relocation types which
don't go through GOT table also, but we are doing GOT entry counting for
them, this will cause GOT table contain useless entries though no
correctness issue. I will cleanup those later.
2015-07-24 Jiong Wang <jiong.wang@arm.com>
bfd/
* elfnn-aarch64.c (IS_AARCH64_TLS_RELOC): Recognize
BFD_RELOC_AARCH64_TLSLD_ADD_DTPREL_LO12.
(aarch64_reloc_got_type): Likewise.
(elfNN_aarch64_final_link_relocate): Likewise.
(elfNN_aarch64_relocate_section): Likewise.
* elfxx-aarch64.c (_bfd_aarch64_elf_put_addend): Likewise.
(_bfd_aarch64_elf_resolve_relocation): Likewise.
ld/testsuite/
* ld-aarch64/emit-relocs-529.s: New testcase.
* ld-aarch64/emit-relocs-529-overflow.s: Likewise.
* ld-aarch64/emit-relocs-86.s: Likewise.
* ld-aarch64/emit-relocs-86-overflow.s: Likewise.
* ld-aarch64/emit-relocs-529.d: New expectation file.
* ld-aarch64/emit-relocs-529-overflow.d: Likewise.
* ld-aarch64/emit-relocs-86.d: Likewise.
* ld-aarch64/emit-relocs-86-overflow.d: Likewise.
* ld-aarch64/aarch64-elf.exp: Run new testcases.
--
Regards,
Jiong
diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c
index eab649b..88524f5 100644
--- a/bfd/elfnn-aarch64.c
+++ b/bfd/elfnn-aarch64.c
@@ -174,6 +174,7 @@
|| (R_TYPE) == BFD_RELOC_AARCH64_TLSIE_LD64_GOTTPREL_LO12_NC \
|| (R_TYPE) == BFD_RELOC_AARCH64_TLSIE_LD32_GOTTPREL_LO12_NC \
|| (R_TYPE) == BFD_RELOC_AARCH64_TLSIE_LD_GOTTPREL_PREL19 \
+ || (R_TYPE) == BFD_RELOC_AARCH64_TLSLD_ADD_DTPREL_LO12 \
|| (R_TYPE) == BFD_RELOC_AARCH64_TLSLD_ADD_LO12_NC \
|| (R_TYPE) == BFD_RELOC_AARCH64_TLSLD_ADR_PAGE21 \
|| (R_TYPE) == BFD_RELOC_AARCH64_TLSLD_ADR_PREL21 \
@@ -4157,6 +4158,7 @@ aarch64_reloc_got_type (bfd_reloc_code_real_type r_type)
case BFD_RELOC_AARCH64_TLSIE_LD_GOTTPREL_PREL19:
return GOT_TLS_IE;
+ case BFD_RELOC_AARCH64_TLSLD_ADD_DTPREL_LO12:
case BFD_RELOC_AARCH64_TLSLE_ADD_TPREL_HI12:
case BFD_RELOC_AARCH64_TLSLE_ADD_TPREL_LO12:
case BFD_RELOC_AARCH64_TLSLE_ADD_TPREL_LO12_NC:
@@ -5061,6 +5063,12 @@ elfNN_aarch64_final_link_relocate (reloc_howto_type *howto,
*unresolved_reloc_p = FALSE;
break;
+ case BFD_RELOC_AARCH64_TLSLD_ADD_DTPREL_LO12:
+ value = _bfd_aarch64_elf_resolve_relocation (bfd_r_type, place, value,
+ signed_addend - dtpoff_base (info),
+ weak_undef_p);
+ break;
+
case BFD_RELOC_AARCH64_TLSLE_ADD_TPREL_HI12:
case BFD_RELOC_AARCH64_TLSLE_ADD_TPREL_LO12:
case BFD_RELOC_AARCH64_TLSLE_ADD_TPREL_LO12_NC:
diff --git a/bfd/elfxx-aarch64.c b/bfd/elfxx-aarch64.c
index 75bc253..f481cd9 100644
--- a/bfd/elfxx-aarch64.c
+++ b/bfd/elfxx-aarch64.c
@@ -249,6 +249,7 @@ _bfd_aarch64_elf_put_addend (bfd *abfd,
case BFD_RELOC_AARCH64_ADD_LO12:
case BFD_RELOC_AARCH64_TLSDESC_ADD_LO12_NC:
case BFD_RELOC_AARCH64_TLSGD_ADD_LO12_NC:
+ case BFD_RELOC_AARCH64_TLSLD_ADD_DTPREL_LO12:
case BFD_RELOC_AARCH64_TLSLD_ADD_LO12_NC:
case BFD_RELOC_AARCH64_TLSLE_ADD_TPREL_HI12:
case BFD_RELOC_AARCH64_TLSLE_ADD_TPREL_LO12:
@@ -398,6 +399,7 @@ _bfd_aarch64_elf_resolve_relocation (bfd_reloc_code_real_type r_type,
case BFD_RELOC_AARCH64_MOVW_G2_NC:
case BFD_RELOC_AARCH64_MOVW_G2_S:
case BFD_RELOC_AARCH64_MOVW_G3:
+ case BFD_RELOC_AARCH64_TLSLD_ADD_DTPREL_LO12:
value = value + addend;
break;
diff --git a/ld/testsuite/ld-aarch64/aarch64-elf.exp b/ld/testsuite/ld-aarch64/aarch64-elf.exp
index ffaf996..13ede51 100644
--- a/ld/testsuite/ld-aarch64/aarch64-elf.exp
+++ b/ld/testsuite/ld-aarch64/aarch64-elf.exp
@@ -51,6 +51,8 @@ run_dump_test "erratum843419"
# Relocation Tests
run_dump_test "weak-undefined"
run_dump_test "emit-relocs-28"
+run_dump_test "emit-relocs-86"
+run_dump_test "emit-relocs-86-overflow"
run_dump_test "emit-relocs-257"
run_dump_test "emit-relocs-257-be"
# 258 is tested in 257
@@ -101,6 +103,8 @@ run_dump_test "emit-relocs-309-low-bad"
run_dump_test "emit-relocs-311"
run_dump_test "emit-relocs-312"
run_dump_test "emit-relocs-313"
+run_dump_test "emit-relocs-529"
+run_dump_test "emit-relocs-529-overflow"
# test addend correctness when --emit-relocs specified for non-relocatable obj.
run_dump_test "emit-relocs-local-addend"
diff --git a/ld/testsuite/ld-aarch64/emit-relocs-529-overflow.d b/ld/testsuite/ld-aarch64/emit-relocs-529-overflow.d
new file mode 100644
index 0000000..6635905
--- /dev/null
+++ b/ld/testsuite/ld-aarch64/emit-relocs-529-overflow.d
@@ -0,0 +1,4 @@
+#source: emit-relocs-529-overflow.s
+#ld: -T relocs.ld -e0 --emit-relocs
+#objdump: -dr
+#error: .*\(.text\+0x\d+\): relocation truncated to fit: R_AARCH64_TLSLD_ADD_DTPREL_LO12 against symbol `v2' .*
diff --git a/ld/testsuite/ld-aarch64/emit-relocs-529-overflow.s b/ld/testsuite/ld-aarch64/emit-relocs-529-overflow.s
new file mode 100644
index 0000000..deddcbf
--- /dev/null
+++ b/ld/testsuite/ld-aarch64/emit-relocs-529-overflow.s
@@ -0,0 +1,11 @@
+ .global v1
+ .size v1, 4096
+ .global v2
+ .section .tdata,"awT",%progbits
+v1:
+ .zero 4096
+v2:
+ .word 0xcafecafe
+
+ .text
+ add x20, x9, #:dtprel_lo12:v2
diff --git a/ld/testsuite/ld-aarch64/emit-relocs-529.d b/ld/testsuite/ld-aarch64/emit-relocs-529.d
new file mode 100644
index 0000000..e2286e5
--- /dev/null
+++ b/ld/testsuite/ld-aarch64/emit-relocs-529.d
@@ -0,0 +1,7 @@
+#source: emit-relocs-529.s
+#ld: -T relocs.ld -e0 --emit-relocs
+#objdump: -dr
+#...
+0000000000010000 <.text>:
+ 10000: 91001134 add x20, x9, #0x4
+ 10000: R_AARCH64_TLSLD_ADD_DTPREL_LO12 v2
diff --git a/ld/testsuite/ld-aarch64/emit-relocs-529.s b/ld/testsuite/ld-aarch64/emit-relocs-529.s
new file mode 100644
index 0000000..ec84f57
--- /dev/null
+++ b/ld/testsuite/ld-aarch64/emit-relocs-529.s
@@ -0,0 +1,10 @@
+ .global v1
+ .global v2
+ .section .tdata,"awT",%progbits
+v1:
+ .word 0xdeaddead
+v2:
+ .word 0xcafecafe
+
+ .text
+ add x20, x9, #:dtprel_lo12:v2
diff --git a/ld/testsuite/ld-aarch64/emit-relocs-86-overflow.d b/ld/testsuite/ld-aarch64/emit-relocs-86-overflow.d
new file mode 100644
index 0000000..fb727b3
--- /dev/null
+++ b/ld/testsuite/ld-aarch64/emit-relocs-86-overflow.d
@@ -0,0 +1,5 @@
+#source: emit-relocs-86-overflow.s
+#as: -mabi=ilp32
+#ld: -m aarch64linux32 -e0 --emit-relocs
+#objdump: -dr
+#error: .*\(.text\+0x\d+\): relocation truncated to fit: R_AARCH64_P32_TLSLD_ADD_DTPREL_LO12 against symbol `v2' .*
diff --git a/ld/testsuite/ld-aarch64/emit-relocs-86-overflow.s b/ld/testsuite/ld-aarch64/emit-relocs-86-overflow.s
new file mode 100644
index 0000000..945a66c
--- /dev/null
+++ b/ld/testsuite/ld-aarch64/emit-relocs-86-overflow.s
@@ -0,0 +1,11 @@
+ .global v1
+ .size v1, 4096
+ .global v2
+ .section .tdata,"awT",%progbits
+v1:
+ .zero 4096
+v2:
+ .word 0xcafecafe
+
+ .text
+ add w20, w9, #:dtprel_lo12:v2
diff --git a/ld/testsuite/ld-aarch64/emit-relocs-86.d b/ld/testsuite/ld-aarch64/emit-relocs-86.d
new file mode 100644
index 0000000..c0f5aca
--- /dev/null
+++ b/ld/testsuite/ld-aarch64/emit-relocs-86.d
@@ -0,0 +1,8 @@
+#source: emit-relocs-86.s
+#as: -mabi=ilp32
+#ld: -m aarch64linux32 -e0 --emit-relocs
+#objdump: -dr
+#...
+00400094 <.text>:
+ 400094: 11001134 add w20, w9, #0x4
+ 400094: R_AARCH64_P32_TLSLD_ADD_DTPREL_LO12 v2
diff --git a/ld/testsuite/ld-aarch64/emit-relocs-86.s b/ld/testsuite/ld-aarch64/emit-relocs-86.s
new file mode 100644
index 0000000..d56d864
--- /dev/null
+++ b/ld/testsuite/ld-aarch64/emit-relocs-86.s
@@ -0,0 +1,10 @@
+ .global v1
+ .global v2
+ .section .tdata,"awT",%progbits
+v1:
+ .word 0xdeaddead
+v2:
+ .word 0xcafecafe
+
+ .text
+ add w20, w9, #:dtprel_lo12:v2