Re: [gold] extraneous warning message from Gold linker on hidden/internal symbol false match (bug 18596)

[Cary Coutant <ccoutant at gmail dot com>]

> A simple fix is to remove the warning, while if it is actually helpful
> to someone, there are options like, to create an option for it, to
> only issue a warning when the symbol is not resolved at last, or
> something else.
>
> diff --git a/gold/resolve.cc b/gold/resolve.cc
> index fdae0ba..af61096 100644
> --- a/gold/resolve.cc
> +++ b/gold/resolve.cc
> @@ -286,15 +286,6 @@ Symbol_table::resolve(Sized_symbol<size>* to,
>             && (to->visibility() == elfcpp::STV_HIDDEN
>                 || to->visibility() == elfcpp::STV_INTERNAL))
>      {
> -      // A dynamic object cannot reference a hidden or internal symbol
> -      // defined in another object.
> -      gold_warning(_("%s symbol '%s' in %s is referenced by DSO %s"),
> -                   (to->visibility() == elfcpp::STV_HIDDEN
> -                    ? "hidden"
> -                    : "internal"),
> -                   to->demangled_name().c_str(),
> -                   to->object()->name().c_str(),
> -                   object->name().c_str());
>        return;
>      }
>    else

Thanks. I've applied the attached patch.

2015-07-20  Yiran Wang  <yiran@google.com>
        Cary Coutant  <ccoutant@gmail.com>

gold/
        PR gold/15574
        * resolve.cc (Symbol_table): Remove warning about references
        from shared objects to hidden symbols.
        * testsuite/Makefile.am (hidden_test): Add hidden_test.syms.
        * testsuite/Makefile.in: Regenerate.
        * testsuite/hidden_test.sh: Check dynamic symbol table; update
        expected error messages.

-cary

Attachment: pr15574.patch
Description: Binary data