This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Fix AVX512 vcvtt?ps2u?qq instructions disassembly (Intel syntax)/18631
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: "Fomin, Alexander" <alexander dot fomin at intel dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Mon, 20 Jul 2015 08:43:56 -0700
- Subject: Re: [PATCH] Fix AVX512 vcvtt?ps2u?qq instructions disassembly (Intel syntax)/18631
- Authentication-results: sourceware.org; auth=none
- References: <43F32C894E7D6F49862D963FA74413E225C074 at CDSMSX102 dot ccr dot corp dot intel dot com>
On Mon, Jul 20, 2015 at 8:31 AM, Fomin, Alexander
<alexander.fomin@intel.com> wrote:
> For Intel AVX512 vcvtt?ps2u?qq instructions with broadcasting enabled,
> memory operand size should be DWORD, not QWORD.
> An additional Intel syntax test with memory operand and broadcasting
> enabled has been added to gas testsuite.
>
> Thanks,
> Alexander
> ----
> gas/testsuite
> * gas/i386avx512dq-intel.d: Replace "QWORD" with "DWORD" in
> vcvtt?ps2u?qq instructions disassembly regexes.
> Add disassembly regex for new test.
> * gas/i386/avx512dq.d: Likewise.
> * gas/i386/avx512dq_vl-intel.d: Likewise.
> * gas/i386/avx512dq_vl.d: Likewise.
> * gas/i386/x86-64-avx512dq-intel.d: Likewise.
> * gas/i386/x86-64-avx512dq.d: Likewise.
> * gas/i386/x86-64-avx512dq_vl-intel.d: Likewise.
> * gas/i386/x86-64-avx512dq_vl.d: Likewise.
> * gas/i386/avx512dq.s: Add new test for Intel syntax with memory
> operand and broadcasting enabled.
> * gas/i386/avx512dq_vl.s: Likewise.
> * gas/i386/x86-64-avx512dq.s: Likewise.
> * gas/i386/x86-64-avx512dq_vl.s: Likewise.
>
> opcodes/
> * i386-dis-evex.h (EVEX_W_0F78_P_2): Replace "EXxmmq" with
> "EXEvexHalfBcstXmmq" for second operand.
^^^ "the" second operand.
> (EVEX_W_0F79_P_2): Likewise
^^^ Missing ".".
> (EVEX_W_0F7A_P_2): Likewise
See above.
> (EVEX_W_0F7B_P_2): Likewise
See above.
> ---
> gas/testsuite/gas/i386/avx512dq-intel.d | 84 +++++------
> gas/testsuite/gas/i386/avx512dq.d | 4 +
> gas/testsuite/gas/i386/avx512dq.s | 4 +
> gas/testsuite/gas/i386/avx512dq_vl-intel.d | 168 +++++++++++-----------
> gas/testsuite/gas/i386/avx512dq_vl.d | 8 ++
> gas/testsuite/gas/i386/avx512dq_vl.s | 8 ++
> gas/testsuite/gas/i386/x86-64-avx512dq-intel.d | 84 +++++------
> gas/testsuite/gas/i386/x86-64-avx512dq.d | 4 +
> gas/testsuite/gas/i386/x86-64-avx512dq.s | 4 +
> gas/testsuite/gas/i386/x86-64-avx512dq_vl-intel.d | 168 +++++++++++-----------
> gas/testsuite/gas/i386/x86-64-avx512dq_vl.d | 8 ++
> gas/testsuite/gas/i386/x86-64-avx512dq_vl.s | 8 ++
> opcodes/i386-dis-evex.h | 8 +-
> 13 files changed, 316 insertions(+), 244 deletions(-)
>
OK with those changes.
Thanks.
--
H.J.