This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [MIPS] Reserve a .gnu_attribute value
- From: "Moore, Catherine" <Catherine_Moore at mentor dot com>
- To: "Maciej W. Rozycki" <macro at linux-mips dot org>, Richard Sandiford <rdsandiford at googlemail dot com>
- Cc: Richard Sandiford <richard dot sandiford at arm dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>, "andrew dot bennett at imgtec dot com" <andrew dot bennett at imgtec dot com>, Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- Date: Wed, 8 Jul 2015 19:38:53 +0000
- Subject: RE: [MIPS] Reserve a .gnu_attribute value
- Authentication-results: sourceware.org; auth=none
- References: <FD3DCEAC5B03E9408544A1E416F112420192C36A82 at NA-MBX-01 dot mgc dot mentorg dot com> <87mvzqbzne dot fsf at e105548-lin dot cambridge dot arm dot com> <FD3DCEAC5B03E9408544A1E416F112420192C3C84C at NA-MBX-01 dot mgc dot mentorg dot com> <87wpyatqvn dot fsf at googlemail dot com> <alpine dot LFD dot 2 dot 11 dot 1507082004480 dot 31060 at eddie dot linux-mips dot org>
> -----Original Message-----
> From: Maciej W. Rozycki [mailto:macro@linux-mips.org]
> Sent: Wednesday, July 08, 2015 3:07 PM
> To: Richard Sandiford
> Cc: Moore, Catherine; Richard Sandiford; binutils@sourceware.org;
> andrew.bennett@imgtec.com; Matthew Fortune
> Subject: Re: [MIPS] Reserve a .gnu_attribute value
>
> On Wed, 8 Jul 2015, Richard Sandiford wrote:
>
> > > diff --git a/binutils/readelf.c b/binutils/readelf.c index
> > > 398a165..86cfd26 100644
> > > --- a/binutils/readelf.c
> > > +++ b/binutils/readelf.c
> > > @@ -13197,6 +13197,9 @@ print_mips_fp_abi_value (int val)
> > > case Val_GNU_MIPS_ABI_FP_64A:
> > > printf (_("Hard float compat (32-bit CPU, 64-bit FPU)\n"));
> > > break;
> > > + case Val_GNU_MIPS_ABI_FP_NAN2008 :
> > > + printf (_("NaN 2008 compatibility\n"));
> > > + break;
> >
> > No space before ":"
> >
> > OK with that change, thanks.
>
> Shouldn't there be more case values? `Val_GNU_MIPS_ABI_FP_NAN2008'
> was ORed with the lower bits, e.g. `Val_GNU_MIPS_ABI_FP_DOUBLE'.
>
I'm trying to provide a minimal implementation that will ensure that Val_GNU_MIPS_ABI_FP_NAN2008 doesn't get used for anything else. There isn't anything in the upstream repository that will generate or use that bit unless it's by mistake. I thought it would be best to have readelf just indicate that the bit was in use.
Catherine