This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: DJGPP port of binutils broken due to 64 bit cygwin fix.

From: Nicholas Clifton <nickc at redhat dot com>
To: Juan Manuel Guerrero <juan dot guerrero at gmx dot de>, binutils at sourceware dot org, djgpp at delorie dot com
Date: Fri, 12 Jun 2015 14:43:00 +0100
Subject: Re: DJGPP port of binutils broken due to 64 bit cygwin fix.
Authentication-results: sourceware.org; auth=none
References: <55703CF2 dot 5030900 at gmx dot de> <20150609054442 dot GC14752 at bubble dot grove dot modra dot org>

Hi Guys,

> Nick's patchhttps://sourceware.org/ml/binutils/2014-03/msg00270.html> looks wrong ona number of fronts. Why the odd test for a discarded

section?  I think we ought to apply something like the following,
handling not just local but also global symbols defined in discarded
sections.  This also zeros out the relocation field as is done for the
ELF linker.

However, I'm not an expert on the COFF linker, and don't have the
means to test this on a native cygwin toolchain without significant
effort on my part.  So this patch ought to be reviewed by someone
before I commit it.


Well I am all for reverting my patch and replacing it with a better one.

Unfortunately I do not have a COFF test environment either, so it isover to you Juan - does this patch work for you ?


Cheers
  Nick

Follow-Ups:
- Re: DJGPP port of binutils broken due to 64 bit cygwin fix.
  - From: Juan Manuel Guerrero

References:
- Re: DJGPP port of binutils broken due to 64 bit cygwin fix.
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]