This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [gold][aarch64] Patch for erratum-843419 (2 of 2 - fix erratum occurrences)

From: Cary Coutant <ccoutant at gmail dot com>
To: Han Shen <shenhan at google dot com>
Cc: binutils <binutils at sourceware dot org>, Luis Lozano <llozano at google dot com>, Bhaskar <bjanakiraman at google dot com>
Date: Thu, 11 Jun 2015 13:25:30 -0700
Subject: Re: [gold][aarch64] Patch for erratum-843419 (2 of 2 - fix erratum occurrences)
Authentication-results: sourceware.org; auth=none
References: <CACkGtrj3SiMVVJAJK3k4J9nikLXVOZx_evKWBwAFPR3Y3QHnMQ at mail dot gmail dot com> <CAJimCsF4oEm0iZgCfwe_5D1=j35-e9n0OWLm7-1Z04mR7Pk6UQ at mail dot gmail dot com> <CACkGtrihLWY3eskauq05dBg=SbXAGxbdEa75BPYW4Q4ZfARKMg at mail dot gmail dot com> <CAJimCsHaE=Qg6Nbr2+BTcVY3GfWGpDJmF_y6PMZRN6NrOFh0EQ at mail dot gmail dot com> <CACkGtrjvQ67aQau4yDWnF0rOuKLsBgQU5MdXCh_f56Wvb8s5mg at mail dot gmail dot com>

With your last patch, gold won't build at -O0, because the
declarations of "static const int STUB_ADDR_ALIGN" need to be made
outside the class body. I've committed the attached patch to move
these initializations out of the class body.

-cary


2015-06-11  Cary Coutant  <ccoutant@gmail.com>

gold/
        * aarch64.cc (Erratum_stub::STUB_ADDR_ALIGN): Move initialization
        outside class body.
        (Reloc_stub::STUB_ADDR_ALIGN): Likewise.

Attachment: stub-align.patch
Description: Binary data

Follow-Ups:
- Re: [gold][aarch64] Patch for erratum-843419 (2 of 2 - fix erratum occurrences)
  - From: Han Shen

References:
- Re: [gold][aarch64] Patch for erratum-843419 (2 of 2 - fix erratum occurrences)
  - From: Cary Coutant
- Re: [gold][aarch64] Patch for erratum-843419 (2 of 2 - fix erratum occurrences)
  - From: Han Shen
- Re: [gold][aarch64] Patch for erratum-843419 (2 of 2 - fix erratum occurrences)
  - From: Cary Coutant

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]